feat: consensus integration preparation (Sequencer split to BlockExecutor and BlockApplier) [WIP]#900
Draft
RomanBrodetski wants to merge 1 commit intomainfrom
Draft
feat: consensus integration preparation (Sequencer split to BlockExecutor and BlockApplier) [WIP]#900RomanBrodetski wants to merge 1 commit intomainfrom
BlockExecutor and BlockApplier) [WIP]#900RomanBrodetski wants to merge 1 commit intomainfrom
Conversation
BlockExecutor and BlockApplier)BlockExecutor and BlockApplier) [WIP]
…mandSource accordingly. Introduce BlockCanonizer.
f46177e to
552bce5
Compare
Test results184 tests 184 ✅ 18m 43s ⏱️ Results for commit 552bce5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prepares the node for the consensus integration.
There are no changes to node or network behavior.
Main Node wiring is modified:
BlockExecutor(executes, updates mempools) andBlockApplier(saves result to the DB)BlockCanonizerwill wait for the proposed blocks to be canonized by consensus before advancing them in the pipeline - this behavior is stubbed for now.MainNodeCommandSourceso that it can replay blocks recieved from consensus. This behaviour is not currently used (as we don't have consensus yet - ENs are still using theENCommandSource)