[MB_KECCAK_PECTRA] keccak abi optims#329
Open
mabbamOG wants to merge 5 commits intoav_pectra_eth_supportfrom
Open
[MB_KECCAK_PECTRA] keccak abi optims#329mabbamOG wants to merge 5 commits intoav_pectra_eth_supportfrom
mabbamOG wants to merge 5 commits intoav_pectra_eth_supportfrom
Conversation
Author
|
also, i did perform measurements of the "one free limb" u8 chunking trick, as opposed to the current approach where we create all u8 variables and then do quadratic constraints for in/out wiring. they cost the same, so for simplicity i kept the current method which generates all lookup u8 variables |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
we wanted a more compact keccak circuit, it was wasting 25% of constraints/vars on 75% of cycles, roughly. Now we waste 50% of constraints/vars on 25% of cycles. Removing that final waste i consider to be insane work for minimal benefit.
Is this a breaking change?