Skip to content

fix: fix CI#426

Merged
antoniolocascio merged 1 commit intodevfrom
alocascio-fix-ci
Nov 26, 2025
Merged

fix: fix CI#426
antoniolocascio merged 1 commit intodevfrom
alocascio-fix-ci

Conversation

@antoniolocascio
Copy link
Contributor

@antoniolocascio antoniolocascio commented Nov 26, 2025

What ❔

Pin zerocopy version to avoid compilation issue

Why ❔

Is this a breaking change?

  • Yes
  • No

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted.

@antoniolocascio antoniolocascio changed the base branch from main to dev November 26, 2025 06:15
@antoniolocascio antoniolocascio force-pushed the alocascio-fix-ci branch 4 times, most recently from 721187a to 7b6d646 Compare November 26, 2025 06:56
@AntonD3
Copy link
Contributor

AntonD3 commented Nov 26, 2025

To do so, it add the Cargo.lock

But do we really need Cargo.lock for it? Isn't pinning certain version enough?

@antoniolocascio
Copy link
Contributor Author

@AntonD3 it is, it just wasn't working bc I added the pin to workspace deps without any crate actually using it. I had to add it as an explicit dep to basic_system for it to work. We can remove the Cargo.lock now, but should we?

@AntonD3
Copy link
Contributor

AntonD3 commented Nov 26, 2025

We can remove the Cargo.lock now, but should we?

I would remove the lock for workspace, AFAIK, it's a good practice for library crates/crates used by others, because Cargo.lock is ignored for crate when you are importing it. So, you know, it's better to always build it without Cargo.lock(locally/in CI) to be sure that it will be compiled successfully when imported as a dependency

@antoniolocascio
Copy link
Contributor Author

@AntonD3 good point, removed the top-level Cargo.lock

@antoniolocascio antoniolocascio merged commit 791f690 into dev Nov 26, 2025
16 of 17 checks passed
@antoniolocascio antoniolocascio deleted the alocascio-fix-ci branch November 26, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants