feat: add support for updating SL chain id#452
Open
antoniolocascio wants to merge 10 commits intoalocascio-interop-rootsfrom
Open
feat: add support for updating SL chain id#452antoniolocascio wants to merge 10 commits intoalocascio-interop-rootsfrom
antoniolocascio wants to merge 10 commits intoalocascio-interop-rootsfrom
Conversation
antoniolocascio
force-pushed
the
alocascio-sl-chain-id
branch
from
c2ef2a8 to
3e58d32
Compare
| pub upgrade_tx_hash: Bytes32, | ||
| /// Linear keccak256 hash of interop roots | ||
| pub interop_roots_rolling_hash: Bytes32, | ||
| /// New settlement layer chain id, if updated. 0 otherwise. |
Contributor
There was a problem hiding this comment.
Should we explicitly forbid setting it to 0?
Contributor
Author
There was a problem hiding this comment.
No longer applicable in the new version
system_hooks/src/lib.rs
Outdated
| pub mod interop_root_reporter; | ||
| pub mod l1_messenger; | ||
| pub mod l2_base_token; | ||
| pub mod new_sl_chain_id_reporter; |
Contributor
There was a problem hiding this comment.
Maybe rename it to "SystemContextEventHook"?
| ); | ||
| } | ||
|
|
||
| let new_sl_chain_id = U256::from_be_bytes(topics[1].as_u8_array()); |
Contributor
There was a problem hiding this comment.
Validate that it isn't zero?
Contributor
Author
There was a problem hiding this comment.
No longer applicable I think
|
|
||
| use super::history_counter::{HistoryCounter, HistoryCounterSnapshotId}; | ||
|
|
||
| pub type NewSettlementLayerChainIdSnapshotId = HistoryCounterSnapshotId; |
Contributor
There was a problem hiding this comment.
Note: I think we should move all this custom storages from zk_ee
antoniolocascio
force-pushed
the
alocascio-sl-chain-id
branch
from
c17b610 to
4f6b95a
Compare
Contributor
Benchmark report
|
6 tasks
0xVolosnikov
pushed a commit
that referenced
this pull request
Jan 8, 2026
## What ❔ Subset of #452 without tests, as those depend on native prover input run. <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted.
RomanHiden
pushed a commit
to RomanHiden/zksync-os
that referenced
this pull request
Jan 19, 2026
## What ❔ Subset of matter-labs#452 without tests, as those depend on native prover input run. <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds support for setting the settlement layer chain id via a service transaction.
Depends on matter-labs/era-contracts#1926
Why ❔
Is this a breaking change?
Checklist