Skip to content

fix: fix UB in aligned vector#530

Merged
0xVolosnikov merged 3 commits intodevfrom
alocascio-fix-ub
Feb 25, 2026
Merged

fix: fix UB in aligned vector#530
0xVolosnikov merged 3 commits intodevfrom
alocascio-fix-ub

Conversation

@antoniolocascio
Copy link
Contributor

What ❔

The current design of aligned_vector depends on a theoretical UB. This PR removes it.

Why ❔

Is this a breaking change?

  • Yes
  • No

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted.

@antoniolocascio antoniolocascio force-pushed the alocascio-audittens-fixes branch from 05615d7 to c2c60b1 Compare February 24, 2026 11:25
Base automatically changed from alocascio-audittens-fixes to dev February 25, 2026 19:27
@github-actions
Copy link
Contributor

Benchmark report

Benchmark Symbol Base Eff Head Eff (%) Base Raw Head Raw (%) Base Blake Head Blake (%) Base Bigint Head Bigint (%)
block_19299001 process_block 315,731,032 315,681,490 (-0.02%) 273,065,632 273,016,090 (-0.02%) 410,630 410,630 (+0.00%) 9,023,830 9,023,830 (+0.00%)
block_22244135 process_block 197,597,860 197,585,555 (-0.01%) 170,682,068 170,669,763 (-0.01%) 172,040 172,040 (+0.00%) 6,040,788 6,040,788 (+0.00%)
precompiles bn254_ecadd 53,268 53,268 (+0.00%) 47,816 47,816 (+0.00%) 0 0 (+0.00%) 1,363 1,363 (+0.00%)
precompiles bn254_ecmul 728,781 728,781 (+0.00%) 564,593 564,593 (+0.00%) 0 0 (+0.00%) 41,047 41,047 (+0.00%)
precompiles bn254_pairing 72,336,733 72,336,733 (+0.00%) 57,808,589 57,808,589 (+0.00%) 0 0 (+0.00%) 3,632,036 3,632,036 (+0.00%)
precompiles ecrecover 479,155 478,103 (-0.22%) 310,643 309,919 (-0.23%) 0 0 (+0.00%) 42,128 42,046 (-0.19%)
precompiles id 927 927 (+0.00%) 927 927 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles keccak 137,579 137,579 (+0.00%) 137,579 137,579 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles modexp 31,267,898 31,267,857 (-0.00%) 20,610,078 20,610,037 (-0.00%) 0 0 (+0.00%) 2,664,455 2,664,455 (+0.00%)
precompiles p256_verify 748,861 748,861 (+0.00%) 470,169 470,169 (+0.00%) 0 0 (+0.00%) 69,673 69,673 (+0.00%)
precompiles point_evaluation 52,918,413 52,918,413 (+0.00%) 40,570,377 40,570,377 (+0.00%) 0 0 (+0.00%) 3,087,009 3,087,009 (+0.00%)
precompiles process_block 147,545,807 147,547,176 (+0.00%) 118,079,195 118,066,744 (-0.01%) 5,140 5,160 (+0.39%) 7,346,093 7,349,468 (+0.05%)
precompiles process_transaction 73,486,786 73,487,752 (+0.00%) 58,784,322 58,791,784 (+0.01%) 160 160 (+0.00%) 3,674,976 3,673,352 (-0.04%)
precompiles ripemd 8,013 8,013 (+0.00%) 8,013 8,013 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles run_tx_loop 146,895,869 146,895,405 (-0.00%) 117,508,617 117,494,653 (-0.01%) 180 180 (+0.00%) 7,346,093 7,349,468 (+0.05%)
precompiles sha256 13,168 13,168 (+0.00%) 13,168 13,168 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles system_init 46,797 46,785 (-0.03%) 46,797 46,785 (-0.03%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles verify_and_apply_batch 145,652 145,910 (+0.18%) 109,652 109,910 (+0.24%) 2,250 2,250 (+0.00%) 0 0 (+0.00%)

@0xVolosnikov 0xVolosnikov merged commit 6141a22 into dev Feb 25, 2026
16 checks passed
@0xVolosnikov 0xVolosnikov deleted the alocascio-fix-ub branch February 25, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants