[feat] Tests for AllowedSessionsValidator#457
Merged
ly0va merged 31 commits intomatter-labs:mainfrom Jul 11, 2025
Merged
Conversation
Collaborator
|
Additional "unhappy" path testcases requested |
jcsec-security
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive tests for the
AllowedSessionsValidatormodule and updates utility functions to support the new contract. Key changes include the addition of test cases for session validation logic and the integration ofAllowedSessionsValidatorinto the contract fixtures.Tests for
AllowedSessionsValidator:test/AllowedSessionsValidatorTest.ts: Added detailed test cases to validate session actions, including hash generation (both on-chain and off-chain), allowing/disallowing session actions, and handling multiple policies. Tests also cover edge cases like rejecting sessions not explicitly allowed and invalidating previously valid sessions.Updates to utility functions:
test/utils.ts:AllowedSessionsValidatorandAllowedSessionsValidator__factoryto imports. [1] [2]getAllowedSessionsContractandgetAllowedSessionsContractAddressinContractFixturesto deploy and retrieve theAllowedSessionsValidatorcontract.