Conversation
The goal is to keep the e2e tests passing as we merge a branch where they fail.
|
Visit the preview URL for this PR (updated for commit d00f116): https://zksync-auth-server-staging--pr138-ecdsa-sdk-lw7yngx8.web.app (expires Thu, 29 May 2025 15:35:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
A new unified create account interface that adds support for passkey-based account creation and refactors the modular deploy flow without front-end changes.
- Refactored
packages/sdk/src/client/passkey/actions/account.tsto introduceDeployAccountPasskeyArgs, newencodePasskeyModuleDataandfetchAccounthelpers, and cleaned up legacy code. - Updated tests in
account.test.tsto target the new public API and added mocks forparseEventLogs. - Added a new high-level
deployModularAccountinpackages/sdk/src/client/index.tsto combine ECDSA, session, passkey, and paymaster modules.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/sdk/src/client/passkey/actions/account.ts | Extracted passkey module encoding, added fetchAccount, removed legacy fetch/deploy. |
| packages/sdk/src/client/passkey/actions/account.test.ts | Updated imports, mocks, and test cases to exercise the new API. |
| packages/sdk/src/client/index.ts | Introduced deployModularAccount to unify modules and handle paymaster. |
| packages/sdk/src/client/ecdsa/actions/account.ts | Stripped out legacy deploy code, kept only ECDSA fetch logic. |
| .vscode/settings.json | Added JSON/JSONC formatter and NX Console AI rules. |
| .github/instructions/nx.instructions.md | Added NX workspace instructions file (auto-generated). |
Comments suppressed due to low confidence (1)
packages/sdk/src/client/index.ts:104
- [nitpick] The error message is ambiguous when the
AccountCreatedevent is missing. Consider changing it toAccountCreated event not found in transaction receiptfor clarity.
throw new Error("No contract address in transaction receipt");
thanks AI! Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
still fails locally? Trying to undo any breaking changes
thanks AI Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
still isn't using the new factory entry point, but it would be easier to use it if needed! Also add support for recovery, if provided by client
Can be saved or used later, mostly as a demo to show all 3 signer types together.
We want this to be new tests with a new name, not losing the old name tests!
Other updates were made that broke things
jackpooleyml
approved these changes
May 22, 2025
cpb8010
added a commit
that referenced
this pull request
Jul 16, 2025
* feat: get new sdk changes The goal is to keep the e2e tests passing as we merge a branch where they fail. * Update packages/sdk/src/client/index.ts thanks AI! Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: attempt to undo more changes still fails locally? Trying to undo any breaking changes * Update packages/sdk/src/client/passkey/actions/account.test.ts thanks AI Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: use new modular account interface still isn't using the new factory entry point, but it would be easier to use it if needed! Also add support for recovery, if provided by client * feat: create throwaway owner on deployment Can be saved or used later, mostly as a demo to show all 3 signer types together. * fix: undo test renaming We want this to be new tests with a new name, not losing the old name tests! * fix: fully revert passkey deploy test changes Other updates were made that broke things --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A new unified create account interface that can create a passkey account with an ECDSA owner and session.
Additional context
This is a no-front-end changes version of the ecdsa-auth-server change set