Conversation
Using a scope that doesn't exist requires more setup
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the package from @zksync-sso/connector-export to zksync-sso-wagmi-connector to avoid using a non-existent scope, which simplifies package setup and publishing.
Key Changes
- Renamed package from
@zksync-sso/connector-exporttozksync-sso-wagmi-connector - Updated all import statements and references across documentation and examples
- Added new contract addresses to era-sepolia.json configuration
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/connector-export/package.json | Updated package name from scoped to unscoped |
| packages/connector-export/src/index.ts | Updated import example in documentation comment |
| packages/connector-export/README.md | Updated all installation and import examples |
| package.json | Updated workspace dependency reference |
| examples/demo-app/package.json | Updated dependency reference in demo app |
| examples/demo-app/pages/index.vue | Updated import statement in demo code |
| packages/auth-server/stores/era-sepolia.json | Added new contract addresses |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
|
Visit the preview URL for this PR (updated for commit 248331a): https://zksync-auth-server-staging--pr168-rename-package-bx1qen52.web.app (expires Tue, 19 Aug 2025 14:46:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
Hard to undo since key is only in CI, but for future beta deploys
wasn't getting picked up by the next step, attempt 3
Not updated in awhile, hopefully still passes?
cpb8010
changed the title
JackHamer09
previously approved these changes
Aug 1, 2025
Re-enable publisher
Has audit fixes
itsacoyote
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Doing prep for the next release and found these issues
matter-labs/zksync-sso-clave-contracts#459