Merged
Conversation
Want to actually test the publish
Installs correctly, but auth-server is missing deps
Was failing oidc
|
Visit the preview URL for this PR (updated for commit 803898d): https://zksync-auth-server-staging--pr172-publish-connector-x4v9t4ze.web.app (expires Sat, 23 Aug 2025 07:11:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements monitoring and deployment improvements for the OIDC and auth servers, along with package publishing updates. The changes focus on adding Prometheus metrics collection to the salt service and updating deployment configurations.
- Adds Prometheus metrics collection with custom counters and histograms for the salt service
- Updates contract deployment addresses and adds snarkjs dependency management
- Enables publishing of the wagmi connector package alongside the main SDK
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/oidc-server/src/salt-service.ts | Adds Prometheus metrics collection with separate metrics server on port 9090 |
| packages/oidc-server/package.json | Adds prom-client dependency for metrics collection |
| packages/auth-server/stores/local-node.json | Updates contract deployment addresses for local development |
| packages/auth-server/scripts/copy-snarkjs.mjs | Adds script to copy snarkjs browser bundle to public directory |
| packages/auth-server/project.json | Updates build commands to include snarkjs copying |
| packages/auth-server/package.json | Adds snarkjs dependency and copy script |
| packages/auth-server/nuxt.config.ts | Adds default URLs for OIDC service endpoints |
| package.json | Adds snarkjs as root dependency |
| Dockerfile | Exposes additional port 9090 for metrics endpoint |
| .github/workflows/deploy-package.yml | Uncomments and updates wagmi connector publishing workflow |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
itsacoyote
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates for the connector and auth-server
Additional context
Some steps were skipped