Skip to content

Publish connector#172

Merged
cpb8010 merged 7 commits intomainfrom
publish-connector
Aug 18, 2025
Merged

Publish connector#172
cpb8010 merged 7 commits intomainfrom
publish-connector

Conversation

@cpb8010
Copy link
Contributor

@cpb8010 cpb8010 commented Aug 14, 2025

Description

Updates for the connector and auth-server

Additional context

Some steps were skipped

Want to actually test the publish
Installs correctly, but auth-server is missing deps
@github-actions
Copy link

github-actions bot commented Aug 14, 2025

Visit the preview URL for this PR (updated for commit 803898d):

https://zksync-auth-server-staging--pr172-publish-connector-x4v9t4ze.web.app

(expires Sat, 23 Aug 2025 07:11:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7

@cpb8010 cpb8010 requested a review from Copilot August 16, 2025 06:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements monitoring and deployment improvements for the OIDC and auth servers, along with package publishing updates. The changes focus on adding Prometheus metrics collection to the salt service and updating deployment configurations.

  • Adds Prometheus metrics collection with custom counters and histograms for the salt service
  • Updates contract deployment addresses and adds snarkjs dependency management
  • Enables publishing of the wagmi connector package alongside the main SDK

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/oidc-server/src/salt-service.ts Adds Prometheus metrics collection with separate metrics server on port 9090
packages/oidc-server/package.json Adds prom-client dependency for metrics collection
packages/auth-server/stores/local-node.json Updates contract deployment addresses for local development
packages/auth-server/scripts/copy-snarkjs.mjs Adds script to copy snarkjs browser bundle to public directory
packages/auth-server/project.json Updates build commands to include snarkjs copying
packages/auth-server/package.json Adds snarkjs dependency and copy script
packages/auth-server/nuxt.config.ts Adds default URLs for OIDC service endpoints
package.json Adds snarkjs as root dependency
Dockerfile Exposes additional port 9090 for metrics endpoint
.github/workflows/deploy-package.yml Uncomments and updates wagmi connector publishing workflow
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cpb8010 cpb8010 self-assigned this Aug 17, 2025
@cpb8010 cpb8010 added enhancement New feature or request good first issue Good for newcomers labels Aug 17, 2025
@cpb8010 cpb8010 enabled auto-merge (squash) August 17, 2025 21:15
@cpb8010 cpb8010 merged commit a3c4618 into main Aug 18, 2025
11 checks passed
@cpb8010 cpb8010 deleted the publish-connector branch August 18, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants