Conversation
commit c350f2e Author: cbe <cbe@matterlabs.dev> Date: Wed Sep 3 21:01:36 2025 -0700 fix: account deployment testing Attempted to upgrade factory and now paymaster is broken commit deac079 Author: cbe <cbe@matterlabs.dev> Date: Wed Sep 3 19:50:00 2025 -0700 fix: new paymaster This has the new factory commit ddaa1bb Author: cbe <cbe@matterlabs.dev> Date: Wed Sep 3 08:58:43 2025 -0700 fix: deploy new factory with old sso beacon The problem was in the upgrade process a new SSO beacon proxy was deployed for the new implemention instead of re-using the existing one. This was because it used the era-sepolia.json which only contains the contracts necessary for the auth-server and didn't have the SSO Beacon address. The SSO beacon address needs to stay the same because its address is specifically allowed by the sequencer. Might also need to update + fund the paymaster, will test in PR.
|
Visit the preview URL for this PR (updated for commit 2e64576): https://zksync-auth-server-staging--pr180-test-preview-0pmh65vl.web.app (expires Thu, 11 Sep 2025 05:30:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates factory and paymaster contract addresses in era-sepolia configuration to fix OIDC testing that was blocked by an old factory pointing to an unauthorized SSO Account Beacon Proxy.
- Updates contract submodule to new commit with corrected factory
- Replaces factory and paymaster addresses in era-sepolia store configuration
- Temporarily changes salt service URL to localhost for development testing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/contracts | Updates submodule commit to version with corrected factory |
| packages/auth-server/stores/era-sepolia.json | Updates accountFactory and accountPaymaster addresses |
| packages/auth-server/nuxt.config.ts | Changes salt service URL to localhost for development |
| .github/workflows/deploy-preview.yml | Adds salt service URL environment variable for preview deployments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was helpful for debugging locally to avoid CORS, but not really long-term necessary!
ly0va
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating the factory and paymaster because the old factory was pointing to an SSO Account Beacon Proxy that wasn't allowed.
Additional context
This was blocking OIDC testing. I can almost test the OIDC except there's now some passkey validation failures probably because of something with the domain.