feat: add urls to OIDC recovery proof files#182
Merged
Conversation
We'll see if I can even test these
|
Visit the preview URL for this PR (updated for commit 9612f65): https://zksync-auth-server-staging--pr182-test-proof-urls-bcqamhht.web.app (expires Thu, 18 Sep 2025 17:22:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default URLs for OIDC recovery resources to use test endpoints instead of production endpoints. The change enables testing OIDC recovery functionality in non-local environments by pointing to Google Cloud Storage test resources.
- Updates default zkeyUrl from production zksync.dev to Google Cloud Storage test bucket
- Updates default witnessUrl from production zksync.dev to Google Cloud Storage test bucket
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yuliyaalexiev
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Performed the trusted setup and uploaded to buckets I control (for testnet)
Additional context
Here's the result of the command we ran after the ceremony: