Conversation
… can skip passkey dialog
Thank you copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying a specific credential to use during passkey authentication in the Sophon passkey connector. The change allows consumers to provide an optional credential descriptor that constrains which passkey credential should be used for authentication.
- Adds optional
credentialparameter to passkey authentication functions - Updates the authentication flow to use the specified credential when provided
- Imports the required
PublicKeyCredentialDescriptorJSONtype
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/sdk/src/client/passkey/client.ts | Adds optional credential parameter to client config and passes it to authentication request |
| packages/sdk/src/client/passkey/actions/passkey.ts | Updates authentication logic to accept and use optional credential descriptor |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Visit the preview URL for this PR (updated for commit f9f6e68): https://zksync-auth-server-staging--pr183-sophon-passkey-conne-zxkn9atk.web.app (expires Wed, 17 Sep 2025 02:40:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
Description
Re-created from confused branch
Additional context
See: #177