Skip to content

Sophon-passkey-connector#183

Merged
JackHamer09 merged 6 commits intomainfrom
sophon-passkey-connector
Sep 10, 2025
Merged

Sophon-passkey-connector#183
JackHamer09 merged 6 commits intomainfrom
sophon-passkey-connector

Conversation

@cpb8010
Copy link
Contributor

@cpb8010 cpb8010 commented Sep 10, 2025

Description

Re-created from confused branch

Additional context

See: #177

@cpb8010 cpb8010 self-assigned this Sep 10, 2025
@cpb8010 cpb8010 requested a review from Copilot September 10, 2025 02:36
@cpb8010 cpb8010 added the enhancement New feature or request label Sep 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for specifying a specific credential to use during passkey authentication in the Sophon passkey connector. The change allows consumers to provide an optional credential descriptor that constrains which passkey credential should be used for authentication.

  • Adds optional credential parameter to passkey authentication functions
  • Updates the authentication flow to use the specified credential when provided
  • Imports the required PublicKeyCredentialDescriptorJSON type

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/sdk/src/client/passkey/client.ts Adds optional credential parameter to client config and passes it to authentication request
packages/sdk/src/client/passkey/actions/passkey.ts Updates authentication logic to accept and use optional credential descriptor

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit f9f6e68):

https://zksync-auth-server-staging--pr183-sophon-passkey-conne-zxkn9atk.web.app

(expires Wed, 17 Sep 2025 02:40:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7

@JackHamer09 JackHamer09 merged commit f33af0e into main Sep 10, 2025
17 of 18 checks passed
@JackHamer09 JackHamer09 deleted the sophon-passkey-connector branch September 10, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants