feat: integrate Rust WASM SDK for encoding#213
Draft
JackHamer09 wants to merge 56 commits intomainfrom
Draft
Conversation
Still working out the deps
Now need to sign with it!
Getting closer because the failure is in rust now?
now we need to troubleshoot contracts
Provide more hostname options really trying to match the existing flow, but it's still failing signatures
Doing more validation off-chain and logging in rust, it looks like the user is required for these contracts
but now in rust! Needs some more thought, other test now fails locally, so going back to main to debug that
This was touched when attempting to update the other test
The web sdk still needs these? Don't want to blow away and start over
Double revert to an updated one
Gas estimation!?
Going to do more in javascript, but probably need to double check the rust now to see if it's not cheating or double-encoding or something
Giving up on this test until I can test it from the wasm package
Will go back to getting wasm test working
Sometimes get confused and undo
no progress, will need to start debugging contracts
Now need to clean it up
Moving into SDK from client
Cleanup to smaller chunks to better understand data relationships
Signing in a single function
Sometimes it fails when I rebuild the sdk? Very confused, but now have a better way to replicate
Obviously just running anvil won't work
Can encode via alloy
and lockfile for ci
tests are passing locally, let's see what what we get in CI
Keep it simple until we have test coverage
More code cleanup
Were from before
There's lots of stuff leftover from tests that are no longer needed
should also make this easier to review
Really hope this gets the e2e passing in ci again
Simplifies the SDK and better configures the client
Removed debug interface tests
Small changes
This reverts commit 7319a52. This was causing the e2e tests to fail? Very confused on this one
Passkey signature fails?
Going to spend time doing bisect so want this for backup
will need to debug signature encoding in rust
…so-erc4337-ffi-web/src/lib.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Still trash code, but cleaner?
…so-erc4337-ffi-web/Cargo.toml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…so-erc4337-ffi-web/src/lib.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
still very flaky tests
Adds docs
also update tests to better reject and check for errors
Should fix flaky tests
- Use Rust SDK through WASM for all encoding operations - Remove ZKsync-specific dependencies (viem/zksync) - Remove paymaster and EIP-712 logic - Simplify to standard EVM-compatible implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Details