Merged
Conversation
jackpooleyml
force-pushed
the
jack/guardians
branch
2 times, most recently
from
c00fe23 to
02781c6
Compare
jackpooleyml
force-pushed
the
jack/async-signer
branch
from
a42ae5d to
a3ec8de
Compare
jackpooleyml
force-pushed
the
jack/guardians
branch
10 times, most recently
from
57812c0 to
e71bf64
Compare
jackpooleyml
commented
Nov 15, 2025
.../zksync-sso-erc4337/crates/zksync-sso-erc4337-core/src/erc4337/account/erc7579/module/add.rs
Show resolved
Hide resolved
jackpooleyml
force-pushed
the
jack/guardians
branch
from
e71bf64 to
287bcf1
Compare
jackpooleyml
commented
Nov 15, 2025
...s/rust/zksync-sso-erc4337/crates/zksync-sso-erc4337-core/src/erc4337/entry_point/contract.rs
Show resolved
Hide resolved
jackpooleyml
commented
Nov 15, 2025
jackpooleyml
force-pushed
the
jack/guardians
branch
2 times, most recently
from
021c2da to
a393191
Compare
jackpooleyml
force-pushed
the
jack/guardians
branch
2 times, most recently
from
7b59fb3 to
5f54c78
Compare
jackpooleyml
force-pushed
the
jack/guardians
branch
from
5f54c78 to
fc6380e
Compare
jackpooleyml
force-pushed
the
jack/guardians
branch
from
fc6380e to
398ae13
Compare
ly0va
approved these changes
Nov 18, 2025
Member
ly0va
left a comment
ly0va
left a comment
There was a problem hiding this comment.
Next time I suggest making a separate PR for refactoring/renaming stuff, and a separate one with new features
ly0va
reviewed
Nov 18, 2025
...ync-sso-erc4337-core/src/erc4337/account/modular_smart_account/guardian/recovery/finalize.rs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements guardian recovery functionality, as well as cleanup, refactoring and improvements:
paymasterparam is consistently available across most contract writes such that these can be sponsoredCompanion contracts PR: matter-labs/zksync-sso-contracts#46 (can be merged before or after)Merged.