Skip to content

feat: 4337 sdk auth server#228

Merged
JackHamer09 merged 19 commits intomainfrom
4337-sdk-auth-server
Nov 21, 2025
Merged

feat: 4337 sdk auth server#228
JackHamer09 merged 19 commits intomainfrom
4337-sdk-auth-server

Conversation

@JackHamer09
Copy link
Member

@JackHamer09 JackHamer09 commented Nov 18, 2025

Description

  • Move all packages/workflows to 4337 SDK, this includes demo-app, auth server and removing any use of legacy sdk
  • New Auth Server API used for smart account deployments.
  • Add configurable alto bundler server with cors proxy.
  • Removed bank demo

Additional context

The plan later is to completely remove all legacy SDK/contracts from the folder and rename 4337 one's (e.g. sdk-4337 -> sdk)

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Visit the preview URL for this PR (updated for commit bf45ce2):

https://zksync-auth-server-staging--pr228-4337-sdk-auth-server-t34a1nt4.web.app

(expires Fri, 28 Nov 2025 15:15:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7

@JackHamer09 JackHamer09 enabled auto-merge (squash) November 21, 2025 15:24
@cpb8010 cpb8010 requested review from Copilot and cpb8010 and removed request for cpb8010 November 21, 2025 15:29
@cpb8010 cpb8010 added the enhancement New feature or request label Nov 21, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a major migration from the legacy SDK to the 4337 SDK architecture, introducing account abstraction (ERC-4337) support and a new auth server API. The changes include moving all packages and workflows to the 4337 SDK, implementing a configurable Alto bundler with CORS proxy, and removing the legacy bank demo.

Key changes:

  • Complete restructuring of SDK packages with new 4337-based implementations
  • New auth server API for smart account deployments
  • Introduction of Alto bundler with CORS proxy for browser compatibility
  • Migration of authentication and session management to ERC-4337 standard

Reviewed changes

Copilot reviewed 200 out of 237 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/sdk-platforms/web/src/webauthn.ts Updated WebAuthn credential structure to nest public key coordinates
packages/sdk-4337/src/version.ts Added library version constant
packages/sdk-4337/src/index.ts New main export file for SDK modules
packages/sdk-4337/src/errors/* Complete error handling system implementation
packages/sdk-4337/src/connector/index.ts Wagmi connector implementation for ZKsync SSO
packages/sdk-4337/src/communicator/* Popup-based communication system
packages/sdk-4337/src/client/session/* Session management with monitoring and formatting
packages/sdk-4337/src/client/passkey/* Passkey client implementation
packages/sdk-4337/src/client/actions/* Session and deployment actions
packages/sdk-4337/src/client-auth-server/* Auth server RPC types and wallet provider
packages/sdk-4337/src/abi/* Contract ABIs for validators
packages/bundler/* New Alto bundler with CORS proxy
packages/auth-server/* Updated to use 4337 SDK with API-based deployments
packages/connector-export/* Removed (consolidated into main SDK)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@cpb8010 cpb8010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I read everything (that wasn't deleted or moved).

Main things to follow up:

  1. Guardian, OIDC (WIP), demo-app signer, session support on deployment, bank-demo
  2. Very small name changes to session and passkey clients is probably an upgrade
  3. Bundler proxy probably needs more devops thoughts?

@JackHamer09 JackHamer09 merged commit f94f2f6 into main Nov 21, 2025
19 checks passed
@JackHamer09 JackHamer09 deleted the 4337-sdk-auth-server branch November 21, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants