Conversation
|
Visit the preview URL for this PR (updated for commit bf45ce2): https://zksync-auth-server-staging--pr228-4337-sdk-auth-server-t34a1nt4.web.app (expires Fri, 28 Nov 2025 15:15:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
There was a problem hiding this comment.
Pull request overview
This PR implements a major migration from the legacy SDK to the 4337 SDK architecture, introducing account abstraction (ERC-4337) support and a new auth server API. The changes include moving all packages and workflows to the 4337 SDK, implementing a configurable Alto bundler with CORS proxy, and removing the legacy bank demo.
Key changes:
- Complete restructuring of SDK packages with new 4337-based implementations
- New auth server API for smart account deployments
- Introduction of Alto bundler with CORS proxy for browser compatibility
- Migration of authentication and session management to ERC-4337 standard
Reviewed changes
Copilot reviewed 200 out of 237 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/sdk-platforms/web/src/webauthn.ts | Updated WebAuthn credential structure to nest public key coordinates |
| packages/sdk-4337/src/version.ts | Added library version constant |
| packages/sdk-4337/src/index.ts | New main export file for SDK modules |
| packages/sdk-4337/src/errors/* | Complete error handling system implementation |
| packages/sdk-4337/src/connector/index.ts | Wagmi connector implementation for ZKsync SSO |
| packages/sdk-4337/src/communicator/* | Popup-based communication system |
| packages/sdk-4337/src/client/session/* | Session management with monitoring and formatting |
| packages/sdk-4337/src/client/passkey/* | Passkey client implementation |
| packages/sdk-4337/src/client/actions/* | Session and deployment actions |
| packages/sdk-4337/src/client-auth-server/* | Auth server RPC types and wallet provider |
| packages/sdk-4337/src/abi/* | Contract ABIs for validators |
| packages/bundler/* | New Alto bundler with CORS proxy |
| packages/auth-server/* | Updated to use 4337 SDK with API-based deployments |
| packages/connector-export/* | Removed (consolidated into main SDK) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cpb8010
left a comment
There was a problem hiding this comment.
Ok I read everything (that wasn't deleted or moved).
Main things to follow up:
- Guardian, OIDC (WIP), demo-app signer, session support on deployment, bank-demo
- Very small name changes to session and passkey clients is probably an upgrade
- Bundler proxy probably needs more devops thoughts?
Description
Additional context
The plan later is to completely remove all legacy SDK/contracts from the folder and rename 4337 one's (e.g.
sdk-4337->sdk)