Open
Conversation
will help as an example
should avoid using auth server
odds of working in ci are less than that
cpb8010
added
documentation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds ERC-7739 (typed data signing) examples and tests to the demo app, demonstrating how smart accounts can sign EIP-712 typed data and verify signatures on-chain via ERC-1271.
Key Changes
- Added ERC-7739 typed data signing utilities with domain wrapping
- Created new Vue components for typed data signing and passkey address lookup
- Implemented deployment scripts and contract helpers for ERC-1271 verification
- Added comprehensive E2E test for the ERC-7739 flow
- Moved
@openzeppelin/contractsfrom dependencies to devDependencies
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/demo-app/utils/erc7739.ts | New utility functions for ERC-7739 typed data signing and hashing |
| examples/demo-app/components/TypedDataErc7739.vue | Component for signing and verifying ERC-7739 typed data |
| examples/demo-app/components/FindAddressesByPasskey.vue | Extracted passkey address lookup into reusable component |
| examples/demo-app/components/DeploymentResultCard.vue | Extracted deployment result display into reusable component |
| examples/demo-app/smart-contracts/ERC1271Caller.sol | Added validation and debug helper functions |
| examples/demo-app/scripts/deploy-erc1271-caller.sh | Deployment script for ERC1271Caller contract |
| examples/demo-app/tests/web-sdk-test.spec.ts | E2E test for ERC-7739 signature flow |
| examples/demo-app/project.json | New Nx tasks for ERC1271 deployment |
| examples/demo-app/pages/web-sdk-test.vue | Refactored to use new components |
| examples/demo-app/package.json | Moved OpenZeppelin contracts to devDependencies |
| examples/demo-app/foundry.toml | Foundry configuration for Solidity compilation |
| examples/demo-app/remappings.txt | Solidity import remappings |
| docs/sdk/client/typed-data-erc7739-demo.md | Documentation for ERC-7739 demo |
| pnpm-lock.yaml | Updated lockfile for dependency changes |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
will come back to this later
minor cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create erc7739 examples and tests
Additional context
important wasn't included before