Conversation
cpb8010
force-pushed
the
4337-guardian
branch
from
23d0b0e to
4a5ba0b
Compare
|
Visit the preview URL for this PR (updated for commit 258d582): https://zksync-auth-server-staging--pr231-4337-guardian-8e14xei2.web.app (expires Mon, 19 Jan 2026 17:42:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
cpb8010
force-pushed
the
4337-guardian
branch
from
c0b0f4e to
82c785d
Compare
cpb8010
force-pushed
the
4337-guardian
branch
from
f6d12ae to
b3e9b64
Compare
needs testing
hopefully fixes ci
more ci fixes!
cpb8010
force-pushed
the
4337-guardian
branch
from
3f39118 to
0a7fa33
Compare
cpb8010
added
enhancement
this is functionally unused
wasn't setting up correctly so future call failed
kinda passing now?
might need to double check with more manual flows
needs some better page pathing
now need to clean up logging
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 62 out of 87 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests fail locally now ;(
working on getting into passing ci
passing locally still, but hopefully fails
jackpooleyml
left a comment
jackpooleyml
left a comment
There was a problem hiding this comment.
Overall looks good, I think there are still some guardian recovery flow CI failures though.
packages/auth-server/components/account-recovery/AddRecoveryMethodModal.vue
Show resolved
Hide resolved
packages/auth-server/components/account-recovery/oidc-recovery-flow/Step2.vue
Show resolved
Hide resolved
packages/auth-server/components/account-recovery/oidc-recovery-flow/Step4.vue
Show resolved
Hide resolved
hopefully helps ci tests
also change timeouts back
failed locally so it's easier to test, so wanted to save making progress from before
was causing more problems
not sure what the difference was
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 57 out of 82 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jackpooleyml
left a comment
jackpooleyml
left a comment
There was a problem hiding this comment.
Consider removing setTimeout or implementing polling of some kind, other than that looks good 👍
packages/auth-server/pages/recovery/guardian/(actions)/confirm-recovery.vue
Show resolved
Hide resolved
packages/auth-server/pages/recovery/guardian/(actions)/confirm-recovery.vue
Outdated
Show resolved
Hide resolved
packages/auth-server/pages/recovery/guardian/(actions)/confirm-recovery.vue
Outdated
Show resolved
Hide resolved
packages/auth-server/pages/recovery/guardian/(actions)/confirm-recovery.vue
Outdated
Show resolved
Hide resolved
packages/auth-server/pages/recovery/guardian/(actions)/confirm-recovery.vue
Outdated
Show resolved
Hide resolved
packages/auth-server/pages/recovery/guardian/(actions)/confirm-recovery.vue
Outdated
Show resolved
Hide resolved
packages/auth-server/pages/recovery/guardian/(actions)/confirm-recovery.vue
Outdated
Show resolved
Hide resolved
remove timeout and console logs
Description
re-enable guardians
Additional context
oidc still not enabled