Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 640491c): https://zksync-auth-server-staging--pr243-jack-e2e-paymaster-t-9bhdwsad.web.app (expires Fri, 30 Jan 2026 16:49:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
40380df to
810054b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an end-to-end Rust test covering paymaster-sponsored flows in the zksync-sso-erc4337-core crate.
Changes:
- Introduces a new paymaster e2e test that deploys an account via paymaster sponsorship and creates a session.
- Wires the new test module into the
erc4337::paymastermodule undercfg(test). - Exposes
generate_session_prooffrom the sessioncreate.rstest module for reuse by the new paymaster test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.../src/erc4337/paymaster/paymaster_test.rs |
Adds a new e2e paymaster test that deploys via paymaster and creates a session. |
.../src/erc4337/paymaster.rs |
Registers the new paymaster_test module behind cfg(test). |
.../src/erc4337/account/modular_smart_account/session/create.rs |
Makes the test module / helper function visible so other tests can reuse generate_session_proof. |
Comments suppressed due to low confidence (1)
packages/sdk-platforms/rust/zksync-sso-erc4337/crates/zksync-sso-erc4337-core/src/erc4337/account/modular_smart_account/session/create.rs:135
generate_session_proofonly needs to be callable from other test modules within this crate. Consider reducing visibility topub(crate)(orpub(super)if appropriate) so it can’t be referenced from outside the crate’s tests viapubpaths.
pub fn generate_session_proof(
session_spec: &SessionSpec,
account_address: Address,
signer_private_key: &str,
) -> eyre::Result<Bytes> {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...dk-platforms/rust/zksync-sso-erc4337/crates/zksync-sso-erc4337-core/src/erc4337/paymaster.rs
Show resolved
Hide resolved
...st/zksync-sso-erc4337/crates/zksync-sso-erc4337-core/src/erc4337/paymaster/paymaster_test.rs
Outdated
Show resolved
Hide resolved
...7/crates/zksync-sso-erc4337-core/src/erc4337/account/modular_smart_account/session/create.rs
Show resolved
Hide resolved
810054b to
640491c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a e2e paymaster test