Skip to content

chore: add paymaster e2e test#243

Merged
jackpooleyml merged 1 commit intomainfrom
jack/e2e-paymaster-test
Jan 23, 2026
Merged

chore: add paymaster e2e test#243
jackpooleyml merged 1 commit intomainfrom
jack/e2e-paymaster-test

Conversation

@jackpooleyml
Copy link
Contributor

Description

Adds a e2e paymaster test

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Visit the preview URL for this PR (updated for commit 640491c):

https://zksync-auth-server-staging--pr243-jack-e2e-paymaster-t-9bhdwsad.web.app

(expires Fri, 30 Jan 2026 16:49:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7

@jackpooleyml jackpooleyml force-pushed the jack/e2e-paymaster-test branch from 40380df to 810054b Compare January 23, 2026 14:59
@jackpooleyml jackpooleyml changed the base branch from demo-auth-server-e2e to main January 23, 2026 15:00
@jackpooleyml jackpooleyml marked this pull request as ready for review January 23, 2026 15:00
@jackpooleyml jackpooleyml requested a review from cpb8010 January 23, 2026 15:10
cpb8010
cpb8010 previously approved these changes Jan 23, 2026
Copy link
Contributor

@cpb8010 cpb8010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay tests

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an end-to-end Rust test covering paymaster-sponsored flows in the zksync-sso-erc4337-core crate.

Changes:

  • Introduces a new paymaster e2e test that deploys an account via paymaster sponsorship and creates a session.
  • Wires the new test module into the erc4337::paymaster module under cfg(test).
  • Exposes generate_session_proof from the session create.rs test module for reuse by the new paymaster test.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
.../src/erc4337/paymaster/paymaster_test.rs Adds a new e2e paymaster test that deploys via paymaster and creates a session.
.../src/erc4337/paymaster.rs Registers the new paymaster_test module behind cfg(test).
.../src/erc4337/account/modular_smart_account/session/create.rs Makes the test module / helper function visible so other tests can reuse generate_session_proof.
Comments suppressed due to low confidence (1)

packages/sdk-platforms/rust/zksync-sso-erc4337/crates/zksync-sso-erc4337-core/src/erc4337/account/modular_smart_account/session/create.rs:135

  • generate_session_proof only needs to be callable from other test modules within this crate. Consider reducing visibility to pub(crate) (or pub(super) if appropriate) so it can’t be referenced from outside the crate’s tests via pub paths.
    pub fn generate_session_proof(
        session_spec: &SessionSpec,
        account_address: Address,
        signer_private_key: &str,
    ) -> eyre::Result<Bytes> {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jackpooleyml jackpooleyml enabled auto-merge (squash) January 23, 2026 16:31
Copy link
Contributor

@cpb8010 cpb8010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good! 😊

@jackpooleyml jackpooleyml merged commit 44e331e into main Jan 23, 2026
19 checks passed
@jackpooleyml jackpooleyml deleted the jack/e2e-paymaster-test branch January 23, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants