Conversation
testing manually doesn't show the same results?
|
Visit the preview URL for this PR (updated for commit 03734f1): https://zksync-auth-server-staging--pr249-auth-server-paymaste-rtjr45lc.web.app (expires Tue, 30 Dec 2025 06:43:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
There was a problem hiding this comment.
Pull request overview
This PR adds end-to-end tests for paymaster support in the auth-server, building upon previous paymaster integration work. The changes convert previously disabled tests (marked with .fixme) into working tests and add new functionality to verify paymaster behavior.
Key Changes
- Modified test suite to verify paymaster button visibility and session creation with paymaster sponsorship
- Added
sendTokensWithPaymasterfunction to enable ETH transfers with paymaster-sponsored gas fees - Updated development server configuration to use explicit ports and environment variables for better test isolation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
packages/auth-server/project.json |
Updated preview command configuration to set explicit ports (3002 for frontend, 3004 for API) and environment variables, renamed prefix from "Auth-Server:" to "Auth-Frontend:" for clarity |
examples/demo-app/tests/create-account.spec.ts |
Converted two .fixme tests to working tests: one verifying paymaster button presence, another testing session creation with paymaster sponsorship; simplified WebAuthn setup and improved test assertions |
examples/demo-app/pages/index.vue |
Added sendTokensWithPaymaster function to support sending ETH with paymaster-sponsored gas fees; changed button from "Connect (Paymaster)" to "Send 0.1 ETH (Paymaster)" shown when wallet is connected |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
still have stuff to fix and tests, but was able to validate manually
passes locally
now need both
jackpooleyml
left a comment
There was a problem hiding this comment.
Not sure I understand the comment about "sessions use native tx signing" and the bit about not using user ops for som TXs, everything should be not using native tx and instead use user operations AFAIK.
jackpooleyml
left a comment
There was a problem hiding this comment.
LGTM just one question
Description
Created e2e tests
Additional context
follow up on adding paymaster support to auth-server