Skip to content

fix: few more prividium related changes#253

Merged
JackHamer09 merged 12 commits intomainfrom
new-prividium-support
Jan 12, 2026
Merged

fix: few more prividium related changes#253
JackHamer09 merged 12 commits intomainfrom
new-prividium-support

Conversation

@JackHamer09
Copy link
Member

@JackHamer09 JackHamer09 commented Jan 12, 2026

Description

  • Using correct bundler transport on Prividium chains
  • Add session contractCalls abi filtering to prevent bloating
  • eth_chainId support for connector's Signer (to prevent opening popup for such rpc request)
  • Add callPolicy utility export on the zksync-sso/connector similar to old version of the SDK

@JackHamer09 JackHamer09 marked this pull request as draft January 12, 2026 15:55
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

Visit the preview URL for this PR (updated for commit 247adf0):

https://zksync-auth-server-staging--pr253-new-prividium-suppor-920ai5jw.web.app

(expires Mon, 19 Jan 2026 18:21:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7

@JackHamer09 JackHamer09 marked this pull request as ready for review January 12, 2026 16:40
@cpb8010 cpb8010 requested a review from Copilot January 12, 2026 17:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances Prividium chain support in the ZKsync SSO SDK by implementing correct bundler transport selection, optimizing session contract call ABIs, adding eth_chainId RPC method support, and re-exporting the callPolicy utility for backward compatibility.

Changes:

  • Added ABI filtering for session contract calls to reduce bloat by keeping only the targeted function
  • Implemented prividium-aware bundler transport selection in both client and auth server
  • Added eth_chainId support in connector's Signer to avoid unnecessary popup displays
  • Re-exported callPolicy utility for convenient access

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/sdk-4337/src/connector/index.ts Added ABI filtering function, session processing logic, and callPolicy re-export
packages/sdk-4337/src/client-auth-server/rpc.ts Updated schema to make bundlerUrl required and add prividiumMode flag
packages/sdk-4337/src/client-auth-server/Signer.ts Added prividium mode transport logic and eth_chainId support
packages/auth-server/utils/constructReturn.ts Refactored to object parameters and added prividium configuration
packages/auth-server/stores/client.ts Added prividium transport selection for bundler client
packages/auth-server/project.json Removed unused dev:with-api script
packages/auth-server/pages/confirm/index.vue Changed v-else to v-else-if for eth_sendTransaction handling
packages/auth-server/components/views/confirmation/RequestSession.vue Updated constructReturn calls with prividium configuration
packages/auth-server/components/views/confirmation/RequestAccounts.vue Updated constructReturn calls with prividium configuration
packages/auth-server/components/PrividiumLogin.vue Added mx-auto class to center logo
examples/demo-app/scripts/deploy-msa-anvil.sh Moved ANVIL_ACCOUNT_0_KEY variable definition earlier

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@jackpooleyml jackpooleyml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JackHamer09 JackHamer09 enabled auto-merge (squash) January 12, 2026 18:15
@JackHamer09 JackHamer09 merged commit 82a73df into main Jan 12, 2026
13 checks passed
@JackHamer09 JackHamer09 deleted the new-prividium-support branch January 12, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants