Skip to content

fix: production build lazyload walletconnect#260

Merged
cpb8010 merged 4 commits intomainfrom
fix-prod
Jan 15, 2026
Merged

fix: production build lazyload walletconnect#260
cpb8010 merged 4 commits intomainfrom
fix-prod

Conversation

@cpb8010
Copy link
Contributor

@cpb8010 cpb8010 commented Jan 15, 2026

Description

Move dynamic imports

Additional context

fixes prod, using preview build:
image

Copilot AI review requested due to automatic review settings January 15, 2026 05:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes production build issues with WalletConnect/AppKit by moving the initialization from the root app.vue component to a lazy-loaded pattern within the useAppKit composable. The changes implement SSR-safe initialization and create plain chain objects to avoid Viem Proxy serialization issues during build.

Changes:

  • Removed AppKit initialization from app.vue root component
  • Implemented lazy initialization in useAppKit composable with SSR guards
  • Added module-level state tracking to prevent duplicate initialization

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
packages/auth-server/app.vue Removed createAppKit initialization and related imports from root component
packages/auth-server/composables/useAppKit.ts Added lazy initialization logic with SSR guards, plain chain object creation, and module-level state tracking

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

Visit the preview URL for this PR (updated for commit 3c46d13):

https://zksync-auth-server-staging--pr260-fix-prod-8mql8pr4.web.app

(expires Thu, 22 Jan 2026 15:47:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7

@cpb8010 cpb8010 self-assigned this Jan 15, 2026
@cpb8010 cpb8010 added the bug Something isn't working label Jan 15, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cpb8010 cpb8010 merged commit 08f15c5 into main Jan 15, 2026
11 of 12 checks passed
@cpb8010 cpb8010 deleted the fix-prod branch January 15, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants