Conversation
|
Visit the preview URL for this PR (updated for commit 90596ef): https://zksync-auth-server-staging--pr261-session-list-k1dfkdrv.web.app (expires Wed, 28 Jan 2026 17:20:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
have partially passing tests
they run and it's hard to tell if the tests are broken or if the list table is broken in actually getting sessions
still filtering
just required changing how it looks for sessions also cleanup
There was a problem hiding this comment.
Pull request overview
This PR connects the session list functionality with the Rust SDK by implementing active session retrieval and displaying them in the auth-server UI.
Changes:
- Added
get_active_sessions_wasmfunction in Rust to query active sessions from blockchain events - Implemented
listActiveSessionsaction in TypeScript SDK to call the WASM function - Updated auth-server sessions page to use the new API and display session data with proper type conversions
- Added E2E tests to verify sessions page loads correctly
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/sdk-platforms/web/src/bundler.ts | Exports the new get_active_sessions_wasm function from WASM module |
| packages/sdk-platforms/rust/zksync-sso-erc4337/crates/zksync-sso-erc4337-ffi-web/src/lib.rs | Re-exports the session list function for WASM bindings |
| packages/sdk-platforms/rust/zksync-sso-erc4337/crates/zksync-sso-erc4337-ffi-web/src/account/modular_smart_account/session/list.rs | Implements WASM wrapper for querying active sessions from blockchain |
| packages/sdk-platforms/rust/zksync-sso-erc4337/crates/zksync-sso-erc4337-ffi-web/src/account/modular_smart_account/session.rs | Declares the session list module |
| packages/sdk-platforms/rust/zksync-sso-erc4337/crates/zksync-sso-erc4337-ffi-web/src/account/modular_smart_account.rs | Adds session module to modular smart account structure |
| packages/sdk-4337/src/client/actions/sessions.ts | Implements listActiveSessions function with types and documentation |
| packages/sdk-4337/src/client/actions/index.ts | Exports the new session list types and function |
| packages/auth-server/tests/sessions.spec.ts | Adds E2E test to verify sessions page UI loads correctly |
| packages/auth-server/project.json | Adds e2e:session task to run session tests |
| packages/auth-server/pages/dashboard/sessions.vue | Refactors to use new API, adds WASM data conversion logic, and updates error handling |
| packages/auth-server/composables/useAsync.ts | Improves error handling with better error messages and logging |
| packages/auth-server/components/session/row/Row.vue | Updates to work with new session data structure (sessionHash and sessionSpec) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...-erc4337/crates/zksync-sso-erc4337-ffi-web/src/account/modular_smart_account/session/list.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ran non-nightly before, so this is the diff
crossing fingers on this one
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jackpooleyml
left a comment
jackpooleyml
left a comment
There was a problem hiding this comment.
Just a few tiny nits
packages/sdk-platforms/rust/zksync-sso-erc4337/crates/zksync-sso-erc4337-ffi-web/src/lib.rs
Outdated
Show resolved
Hide resolved
error improvements
I can't even test this locally, so this is guess and check
debugging via ci is my favorite
Description
connecting session list with rust sdk
Additional context
has some e2e test coverage