Skip to content

fix: pad bytes32 values for proper abi encoding #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpb8010 merged 2 commits into from
Feb 21, 2025
Merged

fix: pad bytes32 values for proper abi encoding #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c818e15
fix: pad bytes32 values for proper abi encoding
ly0va Feb 11, 2025
18697fe
Merge branch 'main' into lyova-pad-bytes32
cpb8010 Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/sdk/src/utils/encoding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { type Address, encodeAbiParameters, getAbiItem, type Hash, type Hex, parseAbiParameters, toHex } from "viem";
import { type Address, encodeAbiParameters, getAbiItem, type Hash, type Hex, pad, parseAbiParameters, toHex } from "viem";

import { SessionKeyModuleAbi } from "../abi/SessionKeyModule.js";
import { getPeriodIdsForTransaction, type SessionConfig } from "../utils/session.js";
Expand Down Expand Up @@ -52,7 +52,7 @@ export const encodePasskeyModuleParameters = (passkey: { passkeyPublicKey: [Buff
{ type: "string", name: "expectedOrigin" },
],
[
[toHex(passkey.passkeyPublicKey[0]), toHex(passkey.passkeyPublicKey[1])],
[pad(toHex(passkey.passkeyPublicKey[0])), pad(toHex(passkey.passkeyPublicKey[1]))],
passkey.expectedOrigin,
],
);
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk/src/utils/passkey.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { ECDSASigValue } from "@peculiar/asn1-ecc";
import { AsnParser } from "@peculiar/asn1-schema";
import { bigintToBuf, bufToBigint } from "bigint-conversion";
import { Buffer } from "buffer";
import { type Address, encodeAbiParameters, type Hex, toHex } from "viem";
import { type Address, encodeAbiParameters, type Hex, pad, toHex } from "viem";

enum COSEKEYS {
kty = 1, // Key Type
Expand Down Expand Up @@ -324,7 +324,7 @@ export function passkeyHashSignatureResponseFormat(
[
toHex(base64UrlToUint8Array(passkeyResponse.authenticatorData)),
toHex(base64UrlToUint8Array(passkeyResponse.clientDataJSON)),
[toHex(signature.r), toHex(signature.s)],
[pad(toHex(signature.r)), pad(toHex(signature.s))],
],
);
const fullFormattedSig = encodeAbiParameters(
Expand Down
Loading