feat: add OIDC accounts to recovery methods view#74
feat: add OIDC accounts to recovery methods view#74matias-gonz merged 9 commits intofeat/oidc-account-recoveryfrom
Conversation
add getOidcAccounts
|
Visit the preview URL for this PR (updated for commit 44f2e08): https://zksync-auth-server-staging--pr74-oidc-fetch-added-acc-flep7pob.web.app (expires Thu, 27 Feb 2025 19:23:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
add oidc recovery card
remove console logs
matias-gonz
changed the title
calvogenerico
left a comment
calvogenerico
left a comment
There was a problem hiding this comment.
I made a ton of comments, but the most important ones are the console.log and the one about Buffer.
|
|
||
| export const parseOidcData = (oidcData: OidcData): ParsedOidcData => { | ||
| const hexToAscii = (hex: Hex): string => | ||
| Buffer.from(hex.slice(2), "hex").toString("ascii"); |
There was a problem hiding this comment.
I believe that using Buffer here is going to add the Buffer polyfill. If you want you can use ByteVector class that the circuit is exporting. That has a fromHex and a toAsciiString.
| return; | ||
| } catch (err) { | ||
| getOidcAccountsError.value = err as Error; | ||
| return []; |
There was a problem hiding this comment.
Why different return types on each return?
| type="danger" | ||
| class="text-sm lg:w-auto w-full" | ||
| @click="removeGuardian(method.address)" | ||
| v-if="method.method === 'Guardian'" |
There was a problem hiding this comment.
Do we have a remove for our guardians?
If we don't. Can you please add a task in notion?
| </div> | ||
| <div class="flex items-center gap-3"> | ||
| <SparklesIcon class="w-5 h-5 flex-shrink-0" /> | ||
| <span class="font-mono text-sm">{{ method.digest }}</span> |
There was a problem hiding this comment.
This digest it's kind of pointless for the user. Let's leave it like this but let's brainstorm how to improve it. I'm adding a task for this.
use ByteVector instead of buffer
get oidc accounts return type
bump circuits
update lock
nx project dependsOn
submodules
* feat: add getOidcAccounts add getOidcAccounts * feat: add oidc recovery card add oidc recovery card * chore: remove console logs remove console logs * refactor: use ByteVector instead of buffer use ByteVector instead of buffer * fix: get oidc accounts return type get oidc accounts return type * chore: bump circuits bump circuits * chore: update lock update lock * fix: nx project dependsOn nx project dependsOn * fix: add submodules submodules
* feat: add getOidcAccounts add getOidcAccounts * feat: add oidc recovery card add oidc recovery card * chore: remove console logs remove console logs * refactor: use ByteVector instead of buffer use ByteVector instead of buffer * fix: get oidc accounts return type get oidc accounts return type * chore: bump circuits bump circuits * chore: update lock update lock * fix: nx project dependsOn nx project dependsOn * fix: add submodules submodules
* feat: add getOidcAccounts add getOidcAccounts * feat: add oidc recovery card add oidc recovery card * chore: remove console logs remove console logs * refactor: use ByteVector instead of buffer use ByteVector instead of buffer * fix: get oidc accounts return type get oidc accounts return type * chore: bump circuits bump circuits * chore: update lock update lock * fix: nx project dependsOn nx project dependsOn * fix: add submodules submodules
2 participants
Description
Add OIDC accounts to recovery methods view