feat: Add merkle tree to OIDC server#77
Merged
matias-gonz merged 11 commits intofeat/oidc-account-recoveryfrom Mar 10, 2025
Merged
feat: Add merkle tree to OIDC server#77matias-gonz merged 11 commits intofeat/oidc-account-recoveryfrom
matias-gonz merged 11 commits intofeat/oidc-account-recoveryfrom
Conversation
update key registry submodule
update contracts
update abi
update contract updater
add merkle to dict
update contracts
| ); | ||
| } | ||
|
|
||
| private addIssHashToKeys(keys: Key[], issHash: string): Key[] { |
There was a problem hiding this comment.
The typing for this function is weird. If you are adding issHash into key, that means that whatever was in keys wasn't actually a key.
I believe this compiles because of how getNewKeys works. It has this line inside:
return results.filter((key): key is Key => key !== null);
I don't love this because this is hinting that what this function returns is a Key but it's actually missing one attribute. Do you believe we can make the typing more explicit?
The simplest option is maybe add the issHash directly in getNewKeys.
add BaseKey
remove unused function
…ksync-sso into oidc/key-registry-merkle-tree
bump contracts
cpb8010
pushed a commit
that referenced
this pull request
Jul 16, 2025
* chore: update key registry submodule update key registry submodule * chore: update contracts update contracts * chore: update abi update abi * feat: update contract updater update contract updater * chore: add merkle to dict add merkle to dict * chore: update contracts update contracts * refactor: add BaseKey add BaseKey * chore: remove unused function remove unused function * chore: update contracts * chore: bump contracts bump contracts
cpb8010
pushed a commit
that referenced
this pull request
Jul 16, 2025
* chore: update key registry submodule update key registry submodule * chore: update contracts update contracts * chore: update abi update abi * feat: update contract updater update contract updater * chore: add merkle to dict add merkle to dict * chore: update contracts update contracts * refactor: add BaseKey add BaseKey * chore: remove unused function remove unused function * chore: update contracts * chore: bump contracts bump contracts
cpb8010
pushed a commit
that referenced
this pull request
Jul 16, 2025
* chore: update key registry submodule update key registry submodule * chore: update contracts update contracts * chore: update abi update abi * feat: update contract updater update contract updater * chore: add merkle to dict add merkle to dict * chore: update contracts update contracts * refactor: add BaseKey add BaseKey * chore: remove unused function remove unused function * chore: update contracts * chore: bump contracts bump contracts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add merkle tree to OIDC server