[Draft] feat: update SDK to expect random account id#79
Closed
Conversation
This is clearly incomplete, but this conflicts with lots of other changes to how the SDK interacts with the contracts
|
Visit the preview URL for this PR (updated for commit 6e42a17): https://zksync-auth-server-staging--pr79-no-account-id-5u3midya.web.app (expires Wed, 05 Mar 2025 08:55:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
Contributor
Author
|
Combining into #58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Draft] linked to: matter-labs/zksync-sso-clave-contracts#309
Description
The ability to front-run an account id was undesirable, so we're removing the ability to read back the account id directly and instead merging it with the deployment salt that determines the account address.
For applications that do need to embed their own account id to perform a non-passkey account lookup, it will be slightly more effort to find the account unique id.
Additional context
This is 1 of 3 changes breaking the contract ABI, so these other two should merge first before this makes more progress (to avoid merge conficts)