OIDC/correctly generate blinding factor#80
Closed
calvogenerico wants to merge 17 commits intofeat/oidc-account-recoveryfrom
Closed
OIDC/correctly generate blinding factor#80calvogenerico wants to merge 17 commits intofeat/oidc-account-recoveryfrom
calvogenerico wants to merge 17 commits intofeat/oidc-account-recoveryfrom
Conversation
Started to make changes to generate proof locally.
using hex type.
Added real txid in nonce. Added real secure blinding factor.
Base automatically changed from
oidc/generate-proof
to
feat/oidc-account-recovery
February 26, 2025 16:44
… oidc/correctly-generate-blinding-factor
|
Visit the preview URL for this PR (updated for commit 9965e1d): https://zksync-auth-server-staging--pr80-oidc-correctly-gener-5z7jlxke.web.app (expires Wed, 05 Mar 2025 17:04:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
calvogenerico
commented
Feb 26, 2025
| }; | ||
| }; | ||
|
|
||
| export const calculateAddKeyTxHash = async < |
Author
There was a problem hiding this comment.
We need to calculate the hash of the tx that we are going to broadcast to set the new passkey. That's what this method method does.
| return bytesToBigInt(randomValues); | ||
| } | ||
|
|
||
| async function generateProf(): Promise<void> { |
Author
There was a problem hiding this comment.
1- Make oauth flow to calculate oidc digest.
2- This allow us to query user's address.
3- Calculate txhash
4- Second oauth flow, this time using txHash to build the nonce.
5- calculte proof.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Secure blinding factor
Calculating correctly.
Missing: Request new passekey.