matrix: Advertise video size properly when sharing the attachment#188
Merged
Merged
Conversation
Collaborator
|
This seems to break image sending entirely when the media-server is enabled. Without it, sending images works, but I didn't test with video as I couldn't easily find one below 10mb (max what Discord allows). I tested with the CI artifact. Maybe there are some other changes in the master branch already that would cause this odd behaviour? Edit: hmm... something is odd with my setup, as it also doesn't send images with the master branch now. Disregard the above. |
|
From testing it seems fine to me, including image sending as said above as well as video sending. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #187
Maybe we should modularize things into smaller functions to make it clearer.