discord: Properly paginate through all users

bridge/discord/discord.go

@@ -206,21 +206,28 @@ func (b *Bdiscord) Connect() error {
 	// Obtaining guild members and initializing nickname mapping.
 	b.membersMutex.Lock()
 	defer b.membersMutex.Unlock()
-	members, err := b.c.GuildMembers(b.guildID, "", 1000)
-	if err != nil {
-		b.Log.Error("Error obtaining server members: ", err)
-		return err
-	}
-	for _, member := range members {
-		if member == nil {
-			b.Log.Warnf("Skipping missing information for a user.")
-			continue
+	after := ""
+	for {
+		members, err := b.c.GuildMembers(b.guildID, after, 1000)
+		if err != nil {
+			b.Log.Error("Error obtaining server members: ", err)
+			return err
+		}
+		if len(members) == 0 {
+			break
 		}
-		b.userMemberMap[member.User.ID] = member
-		b.nickMemberMap[member.User.Username] = member
-		if member.Nick != "" {
-			b.nickMemberMap[member.Nick] = member
+		for _, member := range members {
+			if member == nil {
+				b.Log.Warnf("Skipping missing information for a user.")
+				continue
+			}
+			b.userMemberMap[member.User.ID] = member
+			b.nickMemberMap[member.User.Username] = member
+			if member.Nick != "" {
+				b.nickMemberMap[member.Nick] = member
+			}
 		}
+		after = members[len(members)-1].User.ID
 	}
 
 	b.c.AddHandler(b.messageCreate)

changelog.md

@@ -72,6 +72,7 @@
 - discord
   - attached files are always downloaded, so when the media server is enabled, URLs can stay valid
     longer than Discord URLs ([#37](https://github.com/matterbridge-org/matterbridge/issues/37), [#114](https://github.com/matterbridge-org/matterbridge/pull/114))
+  - all users in a guild are considered for name lookup instead of only a subset of 1000 ([#198](https://github.com/matterbridge-org/matterbridge/pull/198))
 - irc
   - when there are attachments in the message, the body is now sent instead of being discarded silently ([#156](https://github.com/matterbridge-org/matterbridge/pull/156))
   - when an attachment has no public URL, an error message is printed/logged encouraging the