Skip to content

Update Github Actions, cigolang-lint and apply linter#2

Closed
selfhoster1312 wants to merge 35 commits into
matterbridge-org:masterfrom
selfhoster1312:update-ci-fork
Closed

Update Github Actions, cigolang-lint and apply linter#2
selfhoster1312 wants to merge 35 commits into
matterbridge-org:masterfrom
selfhoster1312:update-ci-fork

Conversation

@selfhoster1312
Copy link
Copy Markdown
Collaborator

Upstream pull request: none
Other fork pull request: bibanon#21

There's still a lot of errors in the linter if you check the entire repo (instead of comparing errors with previous commits), but that's already better i guess?

To quote myself over there (changing the ref to the commit):

Sooooo i spent a few hours playing robot with my keyboard and monkeytyping stuff to get the CI working. I'm disabled a few imho useless lints, and there's just 2 left that don't pass and i think are important and require some level of review:

    musttag
    gosec

Otherwise on this branch golangci-lint should run without simply comparing errors with the previous commit which is a terrible way to accumulate tech debt and let it fall on the first person submitting a PR.

Feel free to review. In particular, this commit deserves special attention: https://github.com/matterbridge-org/matterbridge/commit/5fae6bc4e9607d3e65c4326e2fca2b2760bf48af

Because i have no idea what i'm doing in there i'm merely working around the linter errors and i don't know what's the idiomatic way to handle defer/goroutine errors in golang.

Let's see if the CI gods are with us!

@selfhoster1312
Copy link
Copy Markdown
Collaborator Author

Just seeing there's 35 commits to review and 88 changes files, maybe applying the lints right now on all the codebase is not the best idea after all. I'll open a smaller PR

poVoq pushed a commit to poVoq/matterbridge that referenced this pull request Oct 5, 2025
…message-info

Add info for matrix image messages
@selfhoster1312 selfhoster1312 mentioned this pull request Nov 21, 2025
2 tasks
poVoq pushed a commit that referenced this pull request Apr 11, 2026
 This is a combination of 4 commits.

 This is the 1st commit message:
ah yes, change the changelog

 This is the commit message #2:
this is a good word i think

 This is the commit message #3:
run go fmt because ci error

 This is the commit message #4:
maybe?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant