[GH-1543] Switch scss changed #1544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenyaftw
requested review from
jespino and
chenilim
and removed request for
a team
|
Thanks @jenyaftw! This looks good to me, but @asaadmahmood, could you do a quick review? Not sure how this was broken in the first place, or if we need to refactor the switch css later. |
|
@jenyaftw Tried those changes on the plugin, and those don't look good. Can you post screenshots for how this looks on the plugin and on the local server? |
|
/update-branch |
|
/update-branch |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
asaadmahmood
requested changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed height of outer switch and transition of inner switch
Ticket Link
Issue #1543