Skip to content

[GH-3959] implement Option to "Create New Category" under the "Move To..." option in the sidebar #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[GH-3959] implement Option to "Create New Category" under the "Move To..." option in the sidebar #4057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eef04c9
create new menu for suboption menu
cannalee90 Oct 18, 2022
1299825
show modal when click sub-menu
cannalee90 Oct 18, 2022
71ff5c4
change category of board to newly created one
cannalee90 Oct 20, 2022
9fe4f99
apply review for getting newly created category
cannalee90 Oct 21, 2022
59961f6
change proper parameter name
cannalee90 Oct 26, 2022
3839b8a
add unit test for creating new category
cannalee90 Oct 30, 2022
6700c7d
add unit test for clicking new category
cannalee90 Oct 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion webapp/src/components/createCategory/createCategory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ type Props = {
initialValue?: string
onClose: () => void
title: JSX.Element
onCreate?: (category: Category) => Promise<void>
}

const CreateCategory = (props: Props): JSX.Element => {
Expand Down Expand Up @@ -70,7 +71,8 @@ const CreateCategory = (props: Props): JSX.Element => {
teamID,
} as Category

await mutator.createCategory(category)
const createdCategory = await mutator.createCategory(category)
await props.onCreate?.(createdCategory)
}

props.onClose()
Expand Down
Loading