Pages POC #4396
Open
Pages POC #4396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Doug Lauder <[email protected]>
jespino
requested review from
sbishel,
harshilsharma63,
mgdelacroix,
Rajat-Dabade,
asaadmahmood and
wuwinson
and removed request for
sbishel
jespino
added
2: Dev Review
harshilsharma63
requested changes
Jan 11, 2023
| @@ -0,0 +1,3 @@ | |||
| {{- /* addColumnIfNeeded tableName columnName datatype constraint */ -}} | |||
| {{ addColumnIfNeeded "boards" "is_pages_folder" "boolean" "false"}} | |||
There was a problem hiding this comment.
The last parameter should be "default false" not just false. The current command generates syntax error.
sbishel
reviewed
Jan 19, 2023
There was a problem hiding this comment.
Wow...huge! I didn't see anything egregious, but kept loosing myself. One thing not clear to me from the code is
category -> board -> page(s)
Seems like an extra layer in there. But probably just not clear.
Also, before merging I think we should bug bash both with the feature flag off and on. Let's get a couple spinwicks up and try to bug bash (ff off) next week.
asaadmahmood
requested changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pages POC
Pending work
The most outstanding pending work here is to stabilize the changes in the router, I'm no longer using a new router for pages/boards, I'm using the main router and generating the prefix for the routes based on the urls needed to be generated, none for standalone/app mode, and
/boardsand/pagesfor boards and pages itself.This is not working great, there are some problems specially in team switch while you are in pages/boards, but I think I can sort it out sooner than later.