Agents posts on mobile #9317

crspeller · 2025-11-26T13:26:10Z

Summary

Adds AI agent streaming support to the Mattermost Mobile app, enabling interaction with AI agents similar to the web/desktop experience. The implementation includes:

Real-time streaming: WebSocket streaming of agent responses
Reasoning summaries: Collapsible display of agent reasoning with loading states
Tool call approval: Interactive UI for approving or rejecting tool calls with visual feedback
Citations & annotations: Display of citations with clickable references (no inline references)
Generation controls: Stop and regenerate buttons for managing agent responses

The architecture uses an ephemeral streaming store (StreamingStore) that handles transient WebSocket events (custom_mattermost-ai_uppsdate) and properly cleans up state on generation end, allowing components to seamlessly transition to reading persisted database data through standard POST_EDITED events.

It does NOT include any UI beyond the posts themselves. That UI is in a separate PR: #9318

Also adds a CLAUDE.md file for ease of agentic coding with the mobile app using learnings from making this PR and the follow up.

Ticket Link

https://mattermost.atlassian.net/browse/MM-66762

Device Information

This PR was tested on: Pixel 7 android 16

Screenshots

Release Note

Added AI agent streaming support with real-time message updates, reasoning summaries, tool call approval UI, citations display, and generation controls (stop/regenerate).

Implements Phase 4 from the agents mobile plan: - WebSocket event handling for annotations control signal - CitationsList component displaying sources below agent responses - Collapsible sources section with source count - Each citation shows title, domain, and opens URL on tap - Citations persisted in post.props.annotations - Touch-optimized UI with 44pt minimum tap targets

- Remove optimistic WebSocket event approach that didn't work - Clear component streaming state on ENDED event to force switch to persisted data - Remove delays in streaming store cleanup (500ms and 100ms) - POST_EDITED event now properly updates UI for both accept and reject - Remove debug console.log statements - Fix ESLint issues (unused vars, nested callbacks, nested ternary)

…ify logic

github-actions · 2025-11-26T13:34:39Z

Coverage Comparison Report

Generated on December 08, 2025 at 18:32:14 UTC

+-----------------+------------+------------+-----------+
| Metric          | Main       | This PR    | Diff      |
+-----------------+------------+------------+-----------+
| Lines           |     86.28% |     86.29% |     0.01% |
| Statements      |     86.16% |     86.17% |     0.01% |
| Branches        |     72.54% |     72.64% |     0.10% |
| Functions       |     85.54% |     85.41% |    -0.13% |
+-----------------+------------+------------+-----------+
| Total           |     82.63% |     82.62% |    -0.01% |
+-----------------+------------+------------+-----------+

enahum

Overall fantastic job, most comments are mostly about makeup, great first contribution to this project :)

CLAUDE.md

app/components/post_list/post/post.tsx

app/products/agents/actions/remote/generation_controls.test.ts

enahum · 2025-11-26T23:11:00Z

app/products/agents/store/streaming_store.ts

+
+import {CONTROL_SIGNALS} from '@agents/constants';
+import {StreamingEvents, type StreamingState, type PostUpdateWebsocketMessage} from '@agents/types';
+import {DeviceEventEmitter} from 'react-native';


Wondering if we could have this store use observables instead of emitting events? Did you look into that?

No, just followed the pattern with DeviceEventEmitter for the typing indicator.

ok not a blocker.. but it would be nice to explore the use of observables instead of emitting events.

My reason for this is that observables are better for state management while DeviceEventEmitter is mostly to communicate between native and JS event bridges, sure it works here, but I think its worth exploring. You can check how it was done with @products/calls/state/*

Done. Looks better I think. Good call.

app/products/agents/store/streaming_store.ts

app/products/agents/types/index.ts

app/products/agents/utils.ts

enahum

I don't really have anything blocking, but I would love to hear your response to some of my comments before approving.

enahum · 2025-12-02T02:07:14Z

CLAUDE.md

+
+## Important Development Notes
+- Always run the checks before committing code
+- Always test any changes using the mobile mcp before calling something complete or committing code


curious, what mcp?

https://github.com/mobile-next/mobile-mcp

CLAUDE.md

app/products/agents/components/tool_approval_set/index.tsx

app/products/agents/components/tool_card/index.tsx

enahum · 2025-12-02T04:22:43Z

app/products/agents/store/streaming_store.ts

+
+import {CONTROL_SIGNALS} from '@agents/constants';
+import {StreamingEvents, type StreamingState, type PostUpdateWebsocketMessage} from '@agents/types';
+import {DeviceEventEmitter} from 'react-native';


ok not a blocker.. but it would be nice to explore the use of observables instead of emitting events.

My reason for this is that observables are better for state management while DeviceEventEmitter is mostly to communicate between native and JS event bridges, sure it works here, but I think its worth exploring. You can check how it was done with @products/calls/state/*

app/products/agents/types/index.ts

crspeller · 2025-12-04T21:46:10Z

@enahum Ready for review again. Addressed feedback and moved to using observables.

enahum

Much better with the observables, thank you for that!!

There are a couple of non blocking comments.

Great job on this one!

app/products/agents/components/tool_approval_set/index.tsx

app/products/agents/components/tool_card/index.tsx

enahum · 2025-12-05T00:03:41Z

app/products/agents/store/streaming_store.ts

@@ -0,0 +1,294 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.


nickmisasi

LGTM!

crspeller added 11 commits November 18, 2025 15:07

Agents streaming

35ca61e

Fix bug and lint

af6c000

Add reasoning summaries to mobile agents

c58a94d

Add tool call approval UI for mobile agents

da093ca

Add stop and regenerate controls for mobile agents

251520b

Add tests

c007a58

Refactor agents code: remove unused client mixin, fix bugs, and simpl…

8b5233d

…ify logic

Fixes

3b0664a

Add CLAUDE.md

5398b1c

mm-cloud-bot added the release-note label Nov 26, 2025

crspeller mentioned this pull request Nov 26, 2025

Agents "RHS" view #9318

Open

crspeller added 2: Dev Review Requires review by a core commiter 2: UX Review Requires review by a UX Designer labels Nov 26, 2025

crspeller requested review from asaadmahmood, enahum and nickmisasi November 26, 2025 14:08

enahum requested changes Nov 26, 2025

View reviewed changes

crspeller added 3 commits November 28, 2025 16:08

Review feedback.

7a65373

Review feedback inline functions

a69fc67

Learnings

3068e84

crspeller requested a review from enahum November 28, 2025 16:13

enahum reviewed Dec 2, 2025

View reviewed changes

crspeller added 2 commits December 4, 2025 19:55

Address review feedback: StyleSheet.create, parent mount checks, utils

72f618c

Move to observables

fea5c8d

crspeller requested a review from enahum December 4, 2025 21:45

enahum approved these changes Dec 5, 2025

View reviewed changes

Last style fix

f186a4a

nickmisasi approved these changes Dec 8, 2025

View reviewed changes

Style tweaks

80d68c3

crspeller removed 2: Dev Review Requires review by a core commiter 2: UX Review Requires review by a UX Designer labels Dec 9, 2025

crspeller removed the request for review from asaadmahmood December 9, 2025 11:56

crspeller merged commit 0c675ec into main Dec 9, 2025
6 checks passed

crspeller deleted the agents branch December 9, 2025 11:56

amyblais added this to the v2.36.0 milestone Dec 9, 2025

amyblais added the Docs/Needed Requires documentation label Dec 9, 2025

		@@ -0,0 +1,294 @@
		// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.

Agents posts on mobile #9317

Agents posts on mobile #9317

Uh oh!

Conversation

crspeller commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Ticket Link

Device Information

Screenshots

Release Note

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Comparison Report

Uh oh!

enahum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

enahum left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

crspeller commented Dec 4, 2025

Uh oh!

enahum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickmisasi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

crspeller commented Nov 26, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited

Loading