fix(MM-66825): 16kb pagesize #9325

rahimrahman · 2025-12-02T20:54:36Z

Summary

Changes in this PR prepare the app to be in alignment with Google 16KB page size requirement.

Ticket Link

https://mattermost.atlassian.net/browse/MM-66825

Checklist

Added or updated unit tests (required for all new features)
Has UI changes
Includes text changes and localization file updates
Have tested against the 5 core themes to ensure consistency between them.
Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:
Google Pixel 6, Android 16
Google Pixel 8 Emulator, Android 16

Screenshots

Release Note

github-actions · 2025-12-02T21:02:43Z

Coverage Comparison Report

Generated on December 11, 2025 at 21:57:00 UTC

+-----------------+------------+------------+-----------+
| Metric          | Main       | This PR    | Diff      |
+-----------------+------------+------------+-----------+
| Lines           |     86.18% |     86.18% |     0.00% |
| Statements      |     86.06% |     86.06% |     0.00% |
| Branches        |     72.61% |     72.61% |     0.00% |
| Functions       |     85.40% |     85.40% |     0.00% |
+-----------------+------------+------------+-----------+
| Total           |     82.56% |     82.56% |     0.00% |
+-----------------+------------+------------+-----------+

package.json

rahimrahman · 2025-12-04T05:01:54Z

app/components/scheduled_post_indicator/index.tsx

-        <View
-            className='ScheduledPostIndicator'
-        >


Not sure why there's a view with className. But with newer version of expo-image, it's throwing a typescript error.

app/screens/gallery/gallery.tsx

patches/expo-image+2.4.1.patch

rahimrahman · 2025-12-04T05:05:17Z

patches/expo-image+2.0.7.patch

-diff --git a/node_modules/expo-image/android/build.gradle b/node_modules/expo-image/android/build.gradle
-index 11492a2..b6bb941 100644
--- a/node_modules/expo-image/android/build.gradle
-+++ b/node_modules/expo-image/android/build.gradle
-@@ -44,7 +44,7 @@ dependencies {
-   kapt "com.github.bumptech.glide:compiler:${GLIDE_VERSION}"
-   api 'com.caverock:androidsvg-aar:1.4'
-
-  implementation "com.github.penfeizhou.android.animation:glide-plugin:3.0.2"
-+  implementation("com.github.penfeizhou.android.animation:glide-plugin:3.0.3")
-   implementation "com.github.bumptech.glide:avif-integration:${GLIDE_VERSION}"
-
-   api 'com.github.bumptech.glide:okhttp3-integration:4.11.0'


Finally able to remove this now that we are updating to [email protected]

enahum

Let's clarify before approving.. great work on this one

rahimrahman · 2025-12-09T18:46:04Z

@DHaussermann the latest dependency update of expo-web-browser should fix the issue with https://mattermost.atlassian.net/browse/MM-66863 on Android.

I have the app building right now. Should be ready in 20 mins or so.

DHaussermann · 2025-12-10T15:48:00Z

Hi @rahimrahman I have tested the Android fix for SAML and it is working.

Do we know if anything else is needed to merge this? The only other issue found in smoke testing was the share extension did not work reliably on iOS and Android but when I compare to other builds this does not feel new.

…825-16kb-pagesize

DHaussermann · 2025-12-11T21:54:07Z

@rahimrahman given we are merging the base PR #9253 but no longer cherry picking should we remove the label here as well?

do you need to pull feat/MM-65147-upgrade-react-native-0773 up into this branch also to bring it current before the builds will work?

rahimrahman · 2025-12-11T21:55:17Z

@rahimrahman given we are merging the base PR #9253 but no longer cherry picking should we remove the label here as well?

do you need to pull feat/MM-65147-upgrade-react-native-0773 up into this branch also to bring it current before the builds will work?

I just did. About to build Android and to make sure everything build and do a quick test.

update watermelon to 0.28.1-0

5e4306f

mm-cloud-bot added kind/bug Categorizes issue or PR as related to a bug. release-note labels Dec 2, 2025

rahimrahman added the Build App for Android Build the mobile app for Android label Dec 2, 2025

expo@53 and other dependencies

fcec20a

rahimrahman added Build App for Android Build the mobile app for Android and removed Build App for Android Build the mobile app for Android labels Dec 2, 2025

rahimrahman added 2 commits December 2, 2025 19:59

update patch packages

10e07e5

expo-image update

a6103dc

rahimrahman added Build App for Android Build the mobile app for Android and removed Build App for Android Build the mobile app for Android labels Dec 3, 2025

fix typescript errors

304f0ef

rahimrahman added Build App for Android Build the mobile app for Android and removed Build App for Android Build the mobile app for Android labels Dec 3, 2025

rahimrahman changed the base branch from main to feat/MM-65147-upgrade-react-native-0773-with-AppDelegate-swift December 3, 2025 05:07

rahimrahman changed the base branch from feat/MM-65147-upgrade-react-native-0773-with-AppDelegate-swift to feat/MM-65147-upgrade-react-native-0773 December 3, 2025 05:07

update secure pdf viewer pdfium

825c926

rahimrahman added Build App for Android Build the mobile app for Android and removed Build App for Android Build the mobile app for Android labels Dec 4, 2025

rahimrahman requested a review from enahum December 4, 2025 04:54

remove unneeded view

952a5be

rahimrahman commented Dec 4, 2025

View reviewed changes

package.json Show resolved Hide resolved

rahimrahman marked this pull request as ready for review December 4, 2025 05:00

rahimrahman commented Dec 4, 2025

View reviewed changes

app/screens/gallery/gallery.tsx Outdated Show resolved Hide resolved

rahimrahman commented Dec 4, 2025

View reviewed changes

patches/expo-image+2.4.1.patch Show resolved Hide resolved

rahimrahman commented Dec 4, 2025

View reviewed changes

enahum reviewed Dec 4, 2025

View reviewed changes

amyblais added this to the v2.36.0 milestone Dec 4, 2025

update expo-web-browser

2e7aa0e

rahimrahman added Build App for Android Build the mobile app for Android and removed E2E iOS tests for PR Run iOS E2E Detox tests Build Apps for PR Build the mobile app for iOS and Android to test labels Dec 9, 2025

rahimrahman added 6 commits December 10, 2025 12:06

revert changes

ba5d43f

Merge branch 'feat/MM-65147-upgrade-react-native-0773' into fix/MM-66…

fc093a8

…825-16kb-pagesize

update expo-image patch to 2.4.1

98050c5

revert podfile lock

0f0e458

fix expo-image patch file

a2b37c7

fix tsc

b862ecf

rahimrahman added Build App for Android Build the mobile app for Android and removed Build App for Android Build the mobile app for Android labels Dec 11, 2025

amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Dec 11, 2025

rahimrahman added Build App for Android Build the mobile app for Android and removed Build App for Android Build the mobile app for Android labels Dec 11, 2025

Merge branch 'feat/MM-65147-upgrade-react-native-0773' into fix/MM-66…

80b341b

…825-16kb-pagesize

rahimrahman removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Dec 11, 2025

rahimrahman added Build App for Android Build the mobile app for Android and removed Build App for Android Build the mobile app for Android labels Dec 11, 2025

amyblais removed this from the v2.36.0 milestone Dec 12, 2025

DHaussermann added the Build App for iOS Build the mobile app for iOS label Dec 12, 2025

rahimrahman added Build App for Android Build the mobile app for Android and removed Build App for iOS Build the mobile app for iOS Build App for Android Build the mobile app for Android labels Dec 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(MM-66825): 16kb pagesize #9325

fix(MM-66825): 16kb pagesize #9325

rahimrahman commented Dec 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

rahimrahman Dec 4, 2025

Uh oh!

Uh oh!

Uh oh!

rahimrahman Dec 4, 2025

Uh oh!

enahum left a comment

Uh oh!

rahimrahman commented Dec 9, 2025

Uh oh!

DHaussermann commented Dec 10, 2025

Uh oh!

DHaussermann commented Dec 11, 2025

Uh oh!

rahimrahman commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fix(MM-66825): 16kb pagesize #9325

Are you sure you want to change the base?

fix(MM-66825): 16kb pagesize #9325

Conversation

rahimrahman commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Ticket Link

Checklist

Device Information

Screenshots

Release Note

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Comparison Report

Uh oh!

Uh oh!

rahimrahman Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rahimrahman Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

enahum left a comment

Choose a reason for hiding this comment

Uh oh!

rahimrahman commented Dec 9, 2025

Uh oh!

DHaussermann commented Dec 10, 2025

Uh oh!

DHaussermann commented Dec 11, 2025

Uh oh!

rahimrahman commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rahimrahman commented Dec 2, 2025 •

edited

Loading

github-actions bot commented Dec 2, 2025 •

edited

Loading