-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Bor handle burned ws event #9346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Coverage Comparison ReportGenerated on December 12, 2025 at 03:18:14 UTC |
| const postId = msg.data.post_id; | ||
| const operator = DatabaseManager.serverDatabases[serverUrl]?.operator; | ||
| if (!operator) { | ||
| return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: We have now three possible returns: null, {} and {error}. Any strong reason not to return {} in all the cases where we return null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
pvev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Summary
Handled WebSocket event for when a user burns a burn-on-read message for themselves.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-66911
Checklist
E2E iOS tests for PR.Device Information
This PR was tested on: iOS emulator
Screenshots
NA
Release Note