Skip to content

Conversation

@harshilsharma63
Copy link
Member

Summary

Handled WebSocket event for when a user burns a burn-on-read message for themselves.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-66911

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on: iOS emulator

Screenshots

NA

Release Note

Handled WebSocket event for when a user burns a burn-on-read message for themselves.

@harshilsharma63 harshilsharma63 added the 2: Dev Review Requires review by a core commiter label Dec 11, 2025
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Coverage Comparison Report

Generated on December 12, 2025 at 03:18:14 UTC

+-----------------+------------+------------+-----------+
| Metric          | Main       | This PR    | Diff      |
+-----------------+------------+------------+-----------+
| Lines           |     86.18% |     86.18% |     0.00% |
| Statements      |     86.06% |     86.06% |     0.00% |
| Branches        |     72.61% |     72.62% |     0.01% |
| Functions       |     85.40% |     85.40% |     0.00% |
+-----------------+------------+------------+-----------+
| Total           |     82.56% |     82.56% |     0.00% |
+-----------------+------------+------------+-----------+

@amyblais amyblais added this to the v2.36.0 milestone Dec 11, 2025
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Dec 11, 2025
@harshilsharma63 harshilsharma63 added the Build Apps for PR Build the mobile app for iOS and Android to test label Dec 11, 2025
const postId = msg.data.post_id;
const operator = DatabaseManager.serverDatabases[serverUrl]?.operator;
if (!operator) {
return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: We have now three possible returns: null, {} and {error}. Any strong reason not to return {} in all the cases where we return null?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@pvev pvev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@amyblais amyblais removed the 2: Dev Review Requires review by a core commiter label Dec 12, 2025
@harshilsharma63 harshilsharma63 added the 3: QA Review Requires review by a QA tester label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3: QA Review Requires review by a QA tester Build Apps for PR Build the mobile app for iOS and Android to test CherryPick/Approved Meant for the quality or patch release tracked in the milestone release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants