BoR scheduled posts and drafts #9352

harshilsharma63 · 2025-12-12T11:35:51Z

Summary

Added DB migration for adding type column to Scheduled Post and Draft tables.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-66947

Checklist

Added or updated unit tests (required for all new features)
Has UI changes
Includes text changes and localization file updates
Have tested against the 5 core themes to ensure consistency between them.
Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on: iOS emulator

Screenshots

NA

Release Note

None

github-actions · 2025-12-12T13:42:03Z

Coverage Comparison Report

Generated on December 15, 2025 at 05:34:29 UTC

+-----------------+------------+------------+-----------+
| Metric          | Main       | This PR    | Diff      |
+-----------------+------------+------------+-----------+
| Lines           |     86.18% |     86.17% |    -0.01% |
| Statements      |     86.06% |     86.05% |    -0.01% |
| Branches        |     72.61% |     72.61% |     0.00% |
| Functions       |     85.40% |     85.40% |     0.00% |
+-----------------+------------+------------+-----------+
| Total           |     82.56% |     82.55% |    -0.01% |
+-----------------+------------+------------+-----------+

enahum

sorry for the amount of comments

enahum · 2025-12-12T15:21:48Z

app/database/models/server/draft.ts

    @field('update_at') updateAt!: number;
+
+    /** type : The type of post  */
+    @field('type') type?: PostTypesUserCreatable;


this makes it undefined, not null.. the database can store null not undefined.

Ah I see. Thats why we have many fields defined with as fieldName: Type | null

enahum · 2025-12-12T15:21:55Z

app/database/models/server/scheduled_post.ts

    @field('error_code') errorCode!: string;

+    /** type : The type of the post being scheduled */
+    @field('type') type?: PostTypesUserCreatable;


enahum · 2025-12-12T15:22:07Z

app/database/operator/server_data_operator/transformers/post.ts

        scheduledPost.processedAt = raw.processed_at ?? 0;
        scheduledPost.errorCode = raw.error_code || scheduledPost.errorCode;
+
+        // LOL


here we go again

Done. Removed with updated code.

enahum · 2025-12-12T15:22:30Z

app/database/schema/server/table_schemas/draft.ts

        {name: 'root_id', type: 'string', isIndexed: true},
        {name: 'metadata', type: 'string', isOptional: true},
        {name: 'update_at', type: 'number'},
+        {name: 'type', type: 'string'},


missing isOptional

enahum · 2025-12-12T15:22:34Z

app/database/schema/server/table_schemas/scheduled_post.ts

        {name: 'scheduled_at', type: 'number'},
        {name: 'processed_at', type: 'number'},
        {name: 'error_code', type: 'string'},
+        {name: 'type', type: 'string'},


missing isOptional

enahum · 2025-12-12T15:24:31Z

app/database/schema/server/test.ts

                        scheduled_at: {name: 'scheduled_at', type: 'number'},
                        processed_at: {name: 'processed_at', type: 'number'},
                        error_code: {name: 'error_code', type: 'string'},
+                        type: {name: 'type', type: 'string'},


missing isOptional

enahum · 2025-12-12T15:24:37Z

app/database/schema/server/test.ts

                        {name: 'scheduled_at', type: 'number'},
                        {name: 'processed_at', type: 'number'},
                        {name: 'error_code', type: 'string'},
+                        {name: 'type', type: 'string'},


missing isOptional

enahum · 2025-12-12T15:25:04Z

ios/Mattermost.xcodeproj/project.pbxproj

Fail to see the reason for this change

I always get these two diffs - project.pbxproj and Podfile.lockfile. What version of xcode and cocoapods do you use? I'm on xcode 26.1 and pod 1.16.1

Same version, let's just remove this change and the Podfile.lock as well

enahum · 2025-12-12T15:25:20Z

ios/Podfile.lock

enahum · 2025-12-12T15:26:15Z

types/database/models/servers/draft.ts

    updateAt: number;
+
+    /** type : The post type of draft */
+    type?: string;


Suggested change

type?: string;

type: string | null;

this aligns better unless you plan to have the transformer set it to null if undefined

enahum

Approving with the condition to revert the changes in the project and podfile lock files

harshilsharma63 · 2025-12-15T09:09:07Z

@amyblais this isn't necessary for upcoming code freeze date. This can be part of the later release.

harshilsharma63 added 3 commits December 12, 2025 16:28

Added type column to scheduled post and draft table

c3e01de

Merge branch 'main' into bor_scheduled_posts_and_drafts

e31b7b4

removed console log

da73a6e

mm-cloud-bot added the release-note-none label Dec 12, 2025

fixed a test

57b46ee

harshilsharma63 requested review from enahum and larkox December 12, 2025 13:43

enahum requested changes Dec 12, 2025

View reviewed changes

fixes

9c72e3c

enahum approved these changes Dec 15, 2025

View reviewed changes

harshilsharma63 added 2 commits December 15, 2025 10:53

Restored ununtended changes

9bbb662

Merge branch 'main' into bor_scheduled_posts_and_drafts

b322ac8

amyblais added this to the v2.36.0 milestone Dec 15, 2025

amyblais added 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Dec 15, 2025

harshilsharma63 changed the title ~~Bor scheduled posts and drafts~~ Bor scheduled posts and drafts migration Dec 15, 2025

harshilsharma63 changed the title ~~Bor scheduled posts and drafts migration~~ BoR scheduled posts and drafts Dec 15, 2025

amyblais removed this from the v2.36.0 milestone Dec 15, 2025

amyblais removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Dec 15, 2025

BoR scheduled posts and drafts #9352

Are you sure you want to change the base?

BoR scheduled posts and drafts #9352

Conversation

harshilsharma63 commented Dec 12, 2025

Summary

Ticket Link

Checklist

Device Information

Screenshots

Release Note

Uh oh!

github-actions bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Comparison Report

Uh oh!

enahum left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enahum Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enahum left a comment

Choose a reason for hiding this comment

Uh oh!

harshilsharma63 commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Dec 12, 2025 •

edited

Loading

enahum Dec 15, 2025 •

edited

Loading