MM-69160: Fix capitalization and text size in agent mention reminder by mattermost-code · Pull Request #916 · mattermost/mattermost-plugin-agents

mattermost-code · 2026-07-23T15:47:27Z

Summary

When a user replies in an agent thread without @mentioning the bot, an ephemeral reminder is shown ("To respond to an agent you must @mention them. …"). This reminder had two visual issues reported in MM-69160:

The loop-in link text started with a lowercase "c" (click here to loop in @…).
The reminder text rendered at 13px/18px, slightly smaller than regular post text.

This PR makes the smallest scoped fix in webapp/src/components/agent_mention_reminder_post.tsx:

Capitalize the link text to Click here to loop in @….
Match the regular post text size by using 14px/20px (the same size used elsewhere for post-body help text).

QA test steps

Configure an agent bot in a channel (non-DM).
In a channel, post @<bot> Hello and wait for the bot's threaded reply.
Open the thread and post a reply without mentioning the bot.
Observe the ephemeral reminder: the link should read "Click here to loop in @" (capital C) and the text should be the same size as regular post text.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-69160

Screenshots

before	after

Release Note

Fixed the capitalization and text size of the "To respond to an agent you must @mention them" reminder message.

Summary by CodeRabbit

Bug Fixes
- Improved the agent mention reminder link’s readability with standard post-sized text and clearer capitalization.
- Added confirmation and error handling when looping an agent into a conversation.
Tests
- Added coverage for successful, failed, and unavailable agent loop-in actions.
- Added end-to-end validation for reminder visibility, link text, and formatting.

Capitalize "Click here to loop in" and match the reminder's font size (14px/20px) to regular post text. Co-authored-by: mattermost-code <mattermost-code@users.noreply.github.com>

Guards the capitalized loop-in link text and regular post font size. Co-authored-by: mattermost-code <mattermost-code@users.noreply.github.com>

cursor · 2026-07-23T15:47:28Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

chatgpt-codex-connector · 2026-07-23T15:47:31Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

coderabbitai · 2026-07-23T15:49:55Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b5e59dde-e46b-4f15-9c09-e2d0c43e1034

📥 Commits

Reviewing files that changed from the base of the PR and between 553769b and 9fdb69b.

📒 Files selected for processing (5)

e2e/scripts/ci-test-groups.mjs
e2e/tests/agent-mention-reminder/reminder.spec.ts
webapp/src/components/agent_mention_reminder_post.test.tsx
webapp/src/components/agent_mention_reminder_post.tsx
webapp/src/i18n/en.json

📝 Walkthrough

Walkthrough

The agent mention reminder now uses capitalized link text and regular post typography. New component and end-to-end tests cover successful and failed loop-ins, fallback rendering, capitalization, and font sizing, with the E2E test assigned to CI shard 1.

Changes

Agent mention reminder

Layer / File(s)	Summary
Reminder presentation updates `webapp/src/components/agent_mention_reminder_post.tsx`, `webapp/src/i18n/en.json`	The reminder hint typography is adjusted, and the English link text changes from “click here” to “Click here”.
Reminder behavior validation `webapp/src/components/agent_mention_reminder_post.test.tsx`, `e2e/tests/agent-mention-reminder/reminder.spec.ts`, `e2e/scripts/ci-test-groups.mjs`	Unit and E2E tests cover loop-in success, failure, fallback rendering, capitalization, and font size; the E2E spec is added to `e2e-shard-1`.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

mattermost/mattermost-plugin-agents#880: Reworks agent-related E2E spec assignments across CI test groups.

Suggested labels: Setup Cloud Test Server

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarises the main change: fixing the agent mention reminder's capitalization and text size.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch cursor/matty-fixer-mm-69160-e154

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-23T15:50:19Z

🤖 LLM Evaluation Results

OpenAI

⚠️ Overall: 21/28 tests passed (75.0%)

Provider	Total	Passed	Failed	Pass Rate
⚠️ OPENAI	28	21	7	75.0%

❌ Failed Evaluations

Show 7 failures

OPENAI

1. TestReactEval/[openai]_react_cat_message

Score: 0.00
Rubric: The word/emoji is a cat emoji or a heart/love emoji
Reason: The output is the text string "heart_eyes_cat", not an actual cat emoji (e.g., 😺/🐱) or a heart/love emoji (e.g., ❤️/😍).

2. TestConversationMentionHandling/[openai]_conversation_from_attribution_long_thread.json

Score: 0.00
Rubric: is a list of bugs
Reason: The output does not provide any bug list; it requests source data and offers a template for listing bugs instead of listing actual bugs.

3. TestConversationMentionHandling/[openai]_conversation_from_attribution_long_thread.json

Score: 0.00
Rubric: includes a description of each bug
Reason: The output asks the user to provide bug data and offers a template, but it does not actually include descriptions of any specific bugs.

4. TestConversationMentionHandling/[openai]_conversation_from_attribution_long_thread.json

Score: 0.00
Rubric: attributes each bug to a user
Reason: The output requests source data and provides a template, but it does not actually list any bugs or attribute each bug to a specific user.

5. TestConversationMentionHandling/[openai]_conversation_from_attribution_long_thread.json

Score: 0.00
Rubric: attributes the bug about trying to save without a color and the save button not doing anything to @maria.nunez
Reason: The output asks the user to provide source data and does not mention the specific bug (saving without a color / save button not doing anything) nor attribute it to @maria.nunez.

6. TestConversationMentionHandling/[openai]_conversation_from_attribution_long_thread.json

Score: 0.00
Rubric: the bug about the end user being able to change channel banner is attributed to @maria.nunez
Reason: The output does not mention the specific bug about the end user being able to change the channel banner, nor does it attribute that bug to @maria.nunez. It only requests source data and provides a template.

7. TestDirectMessageConversations/[openai]_bot_dm_tool_introspection

Score: 0.50
Rubric: mentions Github and refers to the documentation
Reason: The output refers to documentation (docs.mattermost.com) but does not mention GitHub anywhere, so it does not satisfy the requirement to mention GitHub and refer to the documentation.

Anthropic

⚠️ Overall: 21/28 tests passed (75.0%)

Provider	Total	Passed	Failed	Pass Rate
⚠️ ANTHROPIC	28	21	7	75.0%

❌ Failed Evaluations

Show 7 failures

ANTHROPIC

1. TestReactEval/[anthropic]_react_cat_message

Score: 0.00
Rubric: The word/emoji is a cat emoji or a heart/love emoji
Reason: The output is the text string "heart_eyes_cat", not an actual cat emoji (e.g., 😺/🐱) or heart/love emoji (e.g., ❤️/😍).

2. TestConversationMentionHandling/[anthropic]_conversation_from_attribution_long_thread.json

Score: 0.00
Rubric: is a list of bugs
Reason: The output does not provide a list of bugs; it states it cannot access bug tracking systems and suggests ways to find bugs, but does not enumerate any bug items.

3. TestConversationMentionHandling/[anthropic]_conversation_from_attribution_long_thread.json

Score: 0.00
Rubric: includes a description of each bug
Reason: The output explicitly says it cannot access bug trackers and suggests where to look; it does not provide any actual bug descriptions, nor a description of each bug.

4. TestConversationMentionHandling/[anthropic]_conversation_from_attribution_long_thread.json

Score: 0.00
Rubric: attributes each bug to a user
Reason: The output explicitly says it cannot retrieve bug information and does not list any bugs, nor does it attribute any bug to a user.

5. TestConversationMentionHandling/[anthropic]_conversation_from_attribution_long_thread.json

Score: 0.00
Rubric: attributes the bug about trying to save without a color and the save button not doing anything to @maria.nunez
Reason: The output does not mention @maria.nunez or attribute any specific bugs (saving without a color; save button not doing anything) to her. It only states lack of access and suggests where to search.

6. TestConversationMentionHandling/[anthropic]_conversation_from_attribution_long_thread.json

Score: 0.00
Rubric: the bug about the end user being able to change channel banner is attributed to @maria.nunez
Reason: The output does not mention @maria.nunez or attribute the channel banner change bug to anyone; it only states it lacks access to bug trackers and suggests ways to find issues.

7. TestDirectMessageConversations/[anthropic]_bot_dm_tool_introspection

Score: 0.00
Rubric: mentions Github and refers to the documentation
Reason: The output refers to documentation and links to docs.mattermost.com, but it does not mention GitHub.

This comment was automatically generated by the eval CI pipeline.

cursoragent and others added 2 commits July 23, 2026 15:01

MM-69160: Fix capitalization and text size in agent mention reminder

aeed732

Capitalize "Click here to loop in" and match the reminder's font size (14px/20px) to regular post text. Co-authored-by: mattermost-code <mattermost-code@users.noreply.github.com>

MM-69160: Add e2e coverage for agent mention reminder styling

9fdb69b

Guards the capitalized loop-in link text and regular post font size. Co-authored-by: mattermost-code <mattermost-code@users.noreply.github.com>

coderabbitai Bot approved these changes Jul 23, 2026

View reviewed changes

This was referenced Jul 23, 2026

MM-69160: Fix capitalization and text size in agent mention reminder #917

Merged

[MM-69973] Validate the mention reminder's target post id before building the loop-in request #931

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MM-69160: Fix capitalization and text size in agent mention reminder - #916

MM-69160: Fix capitalization and text size in agent mention reminder#916
mattermost-code wants to merge 2 commits into
masterfrom
cursor/matty-fixer-mm-69160-e154

mattermost-code commented Jul 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

cursor Bot commented Jul 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 23, 2026

Uh oh!

coderabbitai Bot commented Jul 23, 2026

Walkthrough

Changes

Uh oh!

github-actions Bot commented Jul 23, 2026

OPENAI

ANTHROPIC

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mattermost-code commented Jul 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Ticket Link

Screenshots

Release Note

Summary by CodeRabbit

Uh oh!

cursor Bot commented Jul 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 23, 2026

Uh oh!

coderabbitai Bot commented Jul 23, 2026

Walkthrough

Changes

Uh oh!

github-actions Bot commented Jul 23, 2026

🤖 LLM Evaluation Results

OpenAI

❌ Failed Evaluations

OPENAI

Anthropic

❌ Failed Evaluations

ANTHROPIC

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mattermost-code commented Jul 23, 2026 •

edited by coderabbitai Bot

Loading