Skip to content

Commit 5fd0bc5

Browse files
wiggin77claude
andcommitted
Fix missing slash in release notes URL generation
Use url.JoinPath() to properly construct the release notes URL instead of string concatenation, which was missing a leading slash and could fail with URLs that have trailing slashes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 77ee70b commit 5fd0bc5

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

build/manifest/main.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ package main
66
import (
77
"encoding/json"
88
"fmt"
9+
"net/url"
910
"os"
1011
"strings"
1112

@@ -138,7 +139,10 @@ func findManifest() (*model.Manifest, error) {
138139

139140
// If no release notes specified, generate one from the latest tag, if present.
140141
if manifest.ReleaseNotesURL == "" && BuildTagLatest != "" {
141-
manifest.ReleaseNotesURL = manifest.HomepageURL + "releases/tag/" + BuildTagLatest
142+
manifest.ReleaseNotesURL, err = url.JoinPath(manifest.HomepageURL, "releases/tag", BuildTagLatest)
143+
if err != nil {
144+
return nil, errors.Wrap(err, "failed to generate release notes URL")
145+
}
142146
}
143147

144148
return &manifest, nil

0 commit comments

Comments
 (0)