[GH-802] Added config setting for getting notification for draft PRs

[raghavaggarwal2308]

Summary

• Added config setting for getting notification for draft PRs
• Add config setting to make the changes from this PR configurable.

Screenshot:

What to test:

1. When setting is disabled:

• No notification for draft pull request.
• Detailed notification for normal pull request

2. When setting is enable:

• Getting a notification with less details when a draft PR is created.
• Getting a notification with complete details when a draft PR is marked as ready for review.
• Getting a notification with complete details for a normal PR.

How to test:

1. Connect you github account.
2. Create subscription for "pulls" in desired channel
3. Trigger the desired event from github.

Ticket Link

Fixes #802

[wiggin77]

LGTM 👍 Just some small wording changes requested.

[ThiefMaster]

The PR does not really match the issue nor the description... the whole issue was about being able to get notified with full details when the PR is opened regardless of draft state. But currently your setting gives you only the choice between:

• no notifications at all for draft PRs
• short notification for draft PRs + full notification for normal Prs and when marked as ready

It does not cover the case of people using draft PRs because there are open discussion points etc, but otherwise already being relevant!

[raghavaggarwal2308]

@ThiefMaster Can you please clarify what exactly do we need here?

1. Do you want us to get a single notification when a PR (draft/normal) is created and not notification after that?
2. What is the config setting that we need? How should it behave in the on/off state?
   cc: @wiggin77

[AayushChaudhary0001]

While testing this PR following issue is found:

• When the notification setting for draft PRs is set to "False", notifications are still being triggered including all PR details which is not correct.

[Kshitij-Katiyar]

@AayushChaudhary0001 I have fixed the issues reported. Please review

[AayushChaudhary0001]

I found a scenario while retesting in which no notifications are triggered when plugin config setting for draft PR is disabled and a draft PR is marked for review with complete details.

no notifications received:-

[Kshitij-Katiyar]

I found a scenario while retesting in which no notifications are triggered when plugin config setting for draft PR is disabled and a draft PR is marked for review with complete details.

no notifications received:-

@wiggin77 I think we should get a notification whenever a PR is marked readyForReview, no matter the config setting.
What is your opinion on this?

[wiggin77]

@wiggin77 I think we should get a notification whenever a PR is marked readyForReview, no matter the config setting.
What is your opinion on this?

Yes, I agree.

[Kshitij-Katiyar]

@AayushChaudhary0001 Please re-test this PR

[AayushChaudhary0001]

The PR is tested and code changes are working fine on adding config settings for notifications for draft PRs.
LGTM, Approved.