Skip to content

Conversation

@Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Nov 4, 2024

Summary

Added unit test cases for the following functions in server/api.go file

  • GetToken
  • UpdateSettings
  • GetGitHubUser
  • ParseRepo
  • CheckPluginRequest

@Kshitij-Katiyar Kshitij-Katiyar added the 2: Dev Review Requires review by a core committer label Nov 4, 2024
@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Nov 4, 2024
@Kshitij-Katiyar Kshitij-Katiyar changed the title added testcase for some functions in server/api.go Added testcase for some functions in server/api.go Nov 4, 2024
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from server_unit_testcase_template to master December 5, 2024 06:44
Copy link

@raghavaggarwal2308 raghavaggarwal2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kshitij-Katiyar There are a lot of unrelated changes in this PR, can you please check?

@Kshitij-Katiyar
Copy link
Contributor Author

@raghavaggarwal2308 I have resolved the conflicts, please review

@raghavaggarwal2308 raghavaggarwal2308 added this to the v2.4.0 milestone Mar 6, 2025
@raghavaggarwal2308 raghavaggarwal2308 merged commit 3f9f4a7 into master Mar 6, 2025
11 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the add_server/api.go_testcases branch March 6, 2025 10:03
@hanzei
Copy link
Contributor

hanzei commented Mar 12, 2025

@Kshitij-Katiyar
Copy link
Contributor Author

Kshitij-Katiyar commented Mar 12, 2025

@raghavaggarwal2308 The PR broke master, see https://github.com/mattermost/mattermost-plugin-github/actions/runs/13696089769/job/38298725258. Can you please fix that?

@hanzei Created a PR for the same
#885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2: Dev Review Requires review by a core committer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants