-
Notifications
You must be signed in to change notification settings - Fork 163
[MM-945]: Converting user_attribute component and client files to TS and Upgrade mattermost-redux to 10.8.0 #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Kshitij-Katiyar @raghavaggarwal2308 it's tough to know if something was missed in a PR like this when no unit tests seem to exist that cover the changes. I'm thinking we should hold off on TS conversions until we have unit test coverage. Thoughts? |
|
@wiggin77 We are just adding types to the existing files and not adding any functionality, so I am not sure how unit tests will be helpful here. |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
wiggin77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is failing.
|
@wiggin77 FIxed the CI |
|
/update-branch |
|
Error trying to update the PR. |
|
@raghavaggarwal2308 is this up to date with master? |
|
@wiggin77 Yes, its up to date |
wiggin77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Yash-Chakerverti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is tested & all the code changes are working fine.
LGTM
Summary
Converting user_attribute component and client files to TS and other changes"
Upgrade mattermost-redux to 10.8.0
Actual PR
#785