[MM-956]: Added server testcase for webhook.go #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attermost-plugin-github into add_server/command.go_testcases
…attermost-plugin-github into add_server/command.go_testcases
This was referenced Nov 28, 2024
wiggin77
approved these changes
Dec 10, 2024
raghavaggarwal2308
suggested changes
Dec 10, 2024
server/plugin/webhook_test.go
Outdated
| pushEvent: GetMockPushEvent(), | ||
| setup: func() { | ||
| mockKvStore.EXPECT().Get(SubscriptionsKey, gomock.Any()).DoAndReturn(func(key string, value interface{}) error { | ||
| if v, ok := value.(**Subscriptions); ok { |
There was a problem hiding this comment.
Why are we using double * here?
Contributor
Author
There was a problem hiding this comment.
Because pointer of pointer is used here
There was a problem hiding this comment.
@Kshitij-Katiyar I do not think we need the double pointer here.
Contributor
Author
There was a problem hiding this comment.
@raghavaggarwal2308 Double-pointers are very much required here to handle the case of no subscription stored
Using single pointer can make the code more complicated but we can do it.
Let me know your thoughts on this
Contributor
Author
|
@raghavaggarwal2308 FIxed the comments, please re-review |
raghavaggarwal2308
approved these changes
Mar 24, 2025
* [MM-974]: Added testcase fore more functions in webhook.go * review fixes * removed invalid testcase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added server testcase for webhook.go