Skip to content

Conversation

@lieut-data
Copy link
Member

@lieut-data lieut-data commented Jan 21, 2025

Summary

Use mattermost-govet and eslint's header/header to ensure each file begins with the appropriate header, then fix all instances.

// Copyright (c) 2018-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.

Note that this renames LICENSE to LICENSE.txt purely to align on the copyright messaging across repos.

Ticket Link

None

Use `mattermost-govet` and `eslint`'s `header/header` to ensure each
file begins with the appropriate header, then fix all instances.

```
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
```

Note that this renames `LICENSE` to `LICENSE.txt` purely to align on the
copyright messaging across repos.
@lieut-data lieut-data force-pushed the updated-license-header branch from d2b837c to b7ea2e6 Compare January 21, 2025 08:10
Comment on lines +19 to +20
with:
golang-version: "1.22"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unique in all the others in that I couldn't get mattermost-govet as built to run with go vet, it seems because the toolchain version installed was different than go.mod.

Aligning this here fixed the issue... but that technically potentially changes the Go version we're building the core plugin with (even though it should have been that way), and I'm surfacing here for visibility.

Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lieut-data lieut-data marked this pull request as ready for review January 24, 2025 17:24
@lieut-data lieut-data force-pushed the updated-license-header branch from ed09187 to 51e6bdf Compare January 27, 2025 15:51
@lieut-data lieut-data force-pushed the updated-license-header branch from 51e6bdf to e9ab975 Compare January 27, 2025 18:49
@lieut-data lieut-data merged commit 6f5c7bf into master Jan 27, 2025
11 checks passed
@lieut-data lieut-data deleted the updated-license-header branch January 27, 2025 19:18
@Kshitij-Katiyar Kshitij-Katiyar added this to the v2.4.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants