Remove depricated registerPostDropdownMenuComponent #921
Conversation
|
@wiggin77 |
abbas-dependable-naqvi
added
2: Dev Review
| return ( | ||
| <li | ||
| className='MenuItem' | ||
| role='menuitem' | ||
| > | ||
| <button className='style--none'> | ||
| <span className='MenuItem__icon'> | ||
| <GitHubIcon type='menu'/> | ||
| </span> | ||
| {'Create GitHub Issue'} | ||
| </button> | ||
| ); | ||
|
|
||
| return ( | ||
| <li | ||
| className='MenuItem' | ||
| role='menuitem' | ||
| > | ||
| {content} | ||
| </li> | ||
| ); | ||
| } | ||
| </li> | ||
| ); |
There was a problem hiding this comment.
The li and button elements are already rendered by the web app, so you can remove them from here. The span with MenuItem__icon also isn't actually needed because GitHubIcon already includes that inside it, so this should be:
return (
<>
<GitHubIcon type='menu'/>
{'Create GitHub Issue'}
</>
);Testing that locally, the icon is a bit misaligned with the text, but that's fine since it's something I can fix on the web app side (https://mattermost.atlassian.net/browse/MM-65101)
| <GitHubIcon type='menu'/> | ||
| export default function AttachCommentToIssuePostMenuAction() { | ||
| return ( | ||
| <li |
There was a problem hiding this comment.
The same change should be made here as well
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
hmhealey
left a comment
hmhealey
left a comment
There was a problem hiding this comment.
Looks to me like that should work!
Yup, working fine for me. Lets put it up for QA testing. |
arush-vashishtha
left a comment
arush-vashishtha
left a comment
There was a problem hiding this comment.
This PR is tested & all the code changes are working fine.
LGTM
Summary
Remove depricated registerPostDropdownMenuComponent