Skip to content

View Sizing bug when used in a UINavigationController #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JaredCrawford wants to merge 1 commit into
base: master
Choose a base branch
from
Open

View Sizing bug when used in a UINavigationController #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Classes/MGSplitViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,11 @@ - (CGSize)splitViewSizeForOrientation:(UIInterfaceOrientation)theOrientation
// Little bit ugly looking, but it'll still work even if they change the status bar height in future.
float statusBarHeight = MAX((fullScreenRect.size.width - appFrame.size.width), (fullScreenRect.size.height - appFrame.size.height));

float navigationBarHeight = 0;
if ((self.navigationController)&&(!self.navigationController.navigationBarHidden)) {
navigationBarHeight = self.navigationController.navigationBar.frame.size.height;
}

// Initially assume portrait orientation.
float width = fullScreenRect.size.width;
float height = fullScreenRect.size.height;
Expand All @@ -243,6 +248,7 @@ - (CGSize)splitViewSizeForOrientation:(UIInterfaceOrientation)theOrientation

// Account for status bar, which always subtracts from the height (since it's always at the top of the screen).
height -= statusBarHeight;
height -= navigationBarHeight;

return CGSizeMake(width, height);
}
Expand Down