Add python wrapper for SimulationArchive helper C functions; add notebooks#126
Open
yatriks wants to merge 4 commits into
Open
Add python wrapper for SimulationArchive helper C functions; add notebooks#126yatriks wants to merge 4 commits into
SimulationArchive helper C functions; add notebooks#126yatriks wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will:
assist_create_interpolated_simulationC function in Python,SimulationArchives with ASSIST,integrate_or_interpolate.The first two I hope are useful; it's possible that there's a more sustainable way of implementing how to use SimulationArchive's with ASSIST, but I hope this at least captures the procedure for how to do it correctly now given the state.
As for the notebook about the interpolation procedure, it may be that it's only useful for me, and I'm happy to remove it if it adds no value. I'm also not sure if the way that
ax.current_state/sim.particlesstore acceleration (and how thepre_timestep_modificationsare involved) is a 'bug' or just state management I don't understand -- it's a specialized use case and I'm happy to defer to your expertise on if it adds any value.