fix: pin strfry image and fix health check in CI#7
Merged
matthiasdebernardini merged 6 commits intomainfrom Mar 8, 2026
Merged
fix: pin strfry image and fix health check in CI#7matthiasdebernardini merged 6 commits intomainfrom
matthiasdebernardini merged 6 commits intomainfrom
Conversation
Pin strfry Docker image to a specific digest to satisfy zizmor's unpinned-images check. Replace broken health check (curl -sf fails on HTTP 426 Upgrade Required) with status code check that accepts any non-zero HTTP response as "ready". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The strfry image requires a config file at /app/strfry.conf. Service containers can't mount files, so switch to docker run with a generated default config via `strfry export-config`. Also dump container logs on health check failure for easier debugging. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The strfry image requires a config file and export-config also needs one (chicken-and-egg). Add a checked-in CI config with bind=0.0.0.0 (so the container is reachable from the host) and auth disabled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
strfry needs ./strfry-db/ to exist for its LMDB database. Mount a tmpfs at that path so the container can initialize the database. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The container's ulimit (65536) is lower than the default nofiles setting (1000000). Setting nofiles=0 tells strfry not to attempt changing the limit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
delete_event: list-headers returns ok=false (NO_RESULTS) when no headers remain after deletion. Use run() instead of run_ok() and treat NO_RESULTS as a valid post-deletion state. add_item_and_list: event_to_json does not extract the "r" tag as a top-level "resource" field. Check the tags array directly for the ["r", url] entry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sha256:7cf3b97c...) to resolve zizmor'sunpinned-imageswarningcurl -sfsuppresses output on HTTP errors (strfry returns 426 Upgrade Required), causing the check to always fail and timeout. Replaced with status code check that accepts any non-zero HTTP response as "ready"Test plan
🤖 Generated with Claude Code