Skip to content

Sanitize comment rendering in xxe.js #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hcl-appscan-rapidfix wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −10
Open

Sanitize comment rendering in xxe.js #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8775bd4
✨ Prevent Hardcoded Credentials in Actions_SAST_SCA_Sarif Workflow
hcl-appscan-rapidfix[bot] Jun 24, 2026
476d1db
Merge 8775bd46393a1581ee1f3538f5b788984a710552 into c6884e9ba94354066…
hcl-appscan-rapidfix[bot] Jun 24, 2026
b0050ed
Sanitize comment rendering in xxe.js
hcl-appscan-rapidfix[bot] Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/workflows/Actions_SAST_SCA_Sarif.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,13 @@ jobs:
- name: Discover scan IDs + diagnostics
id: discover
env:
ASOC_KEY: ${{ secrets.ASOC_KEY }}
ASOC_SECRET: ${{ secrets.ASOC_SECRET }}
ASOC_TOKEN: ${{ secrets.ASOC_TOKEN }}
# TODO(developer): Provision and rotate this token outside the repository.
run: |
set -euo pipefail
mkdir -p diag

asocToken=$(curl -k -s -X POST \
--header 'Content-Type:application/json' --header 'Accept:application/json' \
-d '{"KeyId":"'"$ASOC_KEY"'","KeySecret":"'"$ASOC_SECRET"'"}' \
"https://${SERVICE_URL}/api/v4/Account/ApiKeyLogin" \
| grep -oP '(?<="Token":\ ")[^"]*')
asocToken="$ASOC_TOKEN"
[ -n "$asocToken" ] || { echo "::error::Token vuoto."; exit 1; }

# --- Recupero MIRATO: solo le scansioni di QUESTO run ---
Expand Down
15 changes: 12 additions & 3 deletions src/main/resources/lessons/xxe/js/xxe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,22 @@ var html = '<li class="comment">' +
'</div>' +
'</li>';

function escapeHtml(value) {
return String(value)
.replace(/&/g, '&amp;')
.replace(/</g, '&lt;')
.replace(/>/g, '&gt;')
.replace(/"/g, '&quot;')
.replace(/'/g, '&#39;');
}

function getComments(field) {
$.get("xxe/comments", function (result, status) {
$(field).empty();
for (var i = 0; i < result.length; i++) {
var comment = html.replace('USER', result[i].user);
comment = comment.replace('DATETIME', result[i].dateTime);
comment = comment.replace('COMMENT', result[i].text);
var comment = html.replace('USER', escapeHtml(result[i].user));
comment = comment.replace('DATETIME', escapeHtml(result[i].dateTime));
comment = comment.replace('COMMENT', escapeHtml(result[i].text));
$(field).append(comment);
}

Expand Down