Add cargo-fuzz target for english pipeline, fix panic #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran cargo-fuzz for a while and it pretty quickly found this panic: minhnhdo/rust-stem#9
I fixed that, and nothing else was found after a few hours of fuzzing ascii. Unsurprisingly it was finding a lot of errors with Unicode input. But to fix those with any confidence that we'll match elasticlunr.js I'll want to move to a UTF-16 pipeline. I'll try to tackle that next.
cc #57 @jobarr-amzn